Update tooltips with new classes #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The li classes changed, so I'm updating so that the tooltip overflow works. I also changed a variable name to be correct.
|
Yeah I made a huge amount of changes over the hackathon + break. We'll need solid unit tests covering all that JS. I've never done client-side unit tests so I need to figure it out. |
mistercrunch
added a commit
that referenced
this pull request
Jan 7, 2016
Update tooltips with new classes
3 tasks
NejcZdovc
added a commit
to blotoutio/superset
that referenced
this pull request
Apr 16, 2021
Resolves apache#100
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 4, 2021
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 17, 2021
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 17, 2021
* refactor: rename channel color to stroke * fix: legend item color and types * feat: can override createTooltip * refactor: renderTooltip
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 24, 2021
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 24, 2021
* refactor: rename channel color to stroke * fix: legend item color and types * feat: can override createTooltip * refactor: renderTooltip
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 25, 2021
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 25, 2021
* refactor: rename channel color to stroke * fix: legend item color and types * feat: can override createTooltip * refactor: renderTooltip
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 26, 2021
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 26, 2021
* refactor: rename channel color to stroke * fix: legend item color and types * feat: can override createTooltip * refactor: renderTooltip
NejcZdovc
added a commit
to blotoutio/superset
that referenced
this pull request
Feb 28, 2022
Resolves apache#100
This was referenced Sep 27, 2022
NejcZdovc
added a commit
to blotoutio/superset
that referenced
this pull request
Nov 8, 2022
Resolves apache#100
mistercrunch
added
the
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The li classes changed for each widget, so I'm updating so that the tooltip overflow works. I also changed a variable name to be correct.