Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump pydruid to 0.6.0 #10014

Merged
merged 2 commits into from
Jun 10, 2020
Merged

Conversation

karen-pal
Copy link
Contributor

@karen-pal karen-pal commented Jun 8, 2020

SUMMARY

Bump version of pydruid: 0.5.9 to 0.6.0
Version 0.5.9 causes installation errors with python 3.7 when running pip install -r requirements-dev.txt. This is fixed by bumping said version.

TEST PLAN

  • Check that superset can now be fresh installed smoothly in 3.7 envs and doesn't cause errors on other envs.
  • Should be tested in different python envs with druid datasources to check it doesn't break stuff.

ADDITIONAL INFORMATION

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2020

Codecov Report

Merging #10014 into master will increase coverage by 3.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10014      +/-   ##
==========================================
+ Coverage   65.59%   68.85%   +3.25%     
==========================================
  Files         585      583       -2     
  Lines       31046    31019      -27     
  Branches     3277     3175     -102     
==========================================
+ Hits        20364    21357     +993     
+ Misses      10501     9552     -949     
+ Partials      181      110      -71     
Flag Coverage Δ
#cypress 53.82% <ø> (?)
#javascript 59.41% <ø> (+0.04%) ⬆️
#python 67.33% <ø> (-2.66%) ⬇️
Impacted Files Coverage Δ
superset/connectors/druid/models.py 28.16% <0.00%> (-54.36%) ⬇️
superset/connectors/base/models.py 86.34% <0.00%> (-2.59%) ⬇️
superset/views/datasource.py 91.80% <0.00%> (-1.64%) ⬇️
superset/views/core.py 75.34% <0.00%> (-0.94%) ⬇️
superset/viz.py 57.06% <0.00%> (-0.09%) ⬇️
superset/sql_parse.py 99.29% <0.00%> (-0.01%) ⬇️
superset/viz_sip38.py 0.00% <0.00%> (ø)
superset/charts/schemas.py 100.00% <0.00%> (ø)
...uperset-frontend/src/views/chartList/ChartList.tsx 61.22% <0.00%> (ø)
...t-frontend/src/explore/controlPanels/EventFlow.jsx
... and 153 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91517a5...323ff43. Read the comment docs.

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good to me, we can let CI check the other python envs. the only thing to fix is the PR title (make sure it adheres to the correct format so that the PRLint checker passes)

@villebro
Copy link
Member

villebro commented Jun 8, 2020

@karen-pal did you try 0.6.0? While it doesn't introduce any new features, its requirements are better aligned with the current Superset dependencies. For instance, Pandas is unpinned from the old 0.25 version. See druid-io/pydruid#219 for a full list of changes.

@karen-pal karen-pal changed the title bump pydruid to 0.5.11 fix:bump pydruid to 0.5.11 Jun 8, 2020
@karen-pal
Copy link
Contributor Author

@karen-pal did you try 0.6.0? While it doesn't introduce any new features, its requirements are better aligned with the current Superset dependencies. For instance, Pandas is unpinned from the old 0.25 version. See druid-io/pydruid#219 for a full list of changes.

I haven't, since I don't really use pydruid/druid. I wanted to bump the version to the one that started supporting python3.7 to stop the installation from crashing. I could bump it to 0.6.0 though!

@etr2460 etr2460 changed the title fix:bump pydruid to 0.5.11 fix: bump pydruid to 0.5.11 Jun 8, 2020
@karen-pal karen-pal changed the title fix: bump pydruid to 0.5.11 fix: bump pydruid to 0.6.0 Jun 10, 2020
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: we should be consistent in how we pin versions (== vs >=).

@etr2460 etr2460 merged commit 1a6b9d7 into apache:master Jun 10, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
* bump pydruid to 0.5.11

* bump pydruid to 0.6.0
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants