refactor: Using self.get_session in security manager #10146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willbarrett
approved these changes
Jun 24, 2020
dpgaspar
reviewed
Jun 25, 2020
superset/security/manager.py
Outdated
| from superset import db | ||
|
|
||
| return db.session.query(self.role_model).filter_by(name="Public").first() | ||
| return self.get_session.query(self.role_model).filter_by(name="Public").first() |
There was a problem hiding this comment.
return self.get_session.query(self.role_model).filter_by(name="Public").one_or_none()
john-bodley
force-pushed
the
john-bodley--refactor-security-manager-get-session
branch
from
cbf4199 to
11c0aaa
Compare
john-bodley
force-pushed
the
john-bodley--refactor-security-manager-get-session
branch
from
11c0aaa to
94a5740
Compare
john-bodley
deleted the
john-bodley--refactor-security-manager-get-session
branch
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
Co-authored-by: John Bodley <john.bodley@airbnb.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
@dpgaspar per your #10034 (comment) I thought there was merit in replacing
db.sessionwithself.get_sessionthroughout the entire security manager.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
CI.
ADDITIONAL INFORMATION