fix: fetch datasets list after dataset created successfully #10290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10290 +/- ##
==========================================
- Coverage 70.54% 65.54% -5.00%
==========================================
Files 599 599
Lines 32075 32075
Branches 3244 3243 -1
==========================================
- Hits 22628 21025 -1603
- Misses 9343 10869 +1526
- Partials 104 181 +77
Continue to review full report at Codecov.
|
etr2460
reviewed
Jul 10, 2020
| }: SubMenuProps) => { | ||
| const [isModalOpen, setIsModalOpen] = useState(false); | ||
| const [selectedMenu, setSelectedMenu] = useState( | ||
| (childs && childs[0] && childs[0].label) || '', |
There was a problem hiding this comment.
is there a need to default to empty string here? if so, you can do childs?.[0]?.label || '' and if not, simply do childs?.[0]?.label and make this a useState<string | undefined> call
There was a problem hiding this comment.
good suggestion! it doesn't need to default to empty string
etr2460
approved these changes
Jul 10, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
subMenuto use hooksBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
https://www.loom.com/share/22f99d27dcc5493a921496a8b3302048
TEST PLAN
ADDITIONAL INFORMATION