feat: add download as image button to explore #10297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etr2460
force-pushed
the
erik-ritter--download-as-image-explore
branch
from
42cdbfd to
fe51734
Compare
|
also cc @ChristianMurphy as the original implementer of this feature in case he has feedback |
ChristianMurphy
approved these changes
Jul 14, 2020
ktmud
approved these changes
Jul 14, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This feature was recently added to charts on dashboards, I'm adding it to explore view as well
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Example screenshot:
TEST PLAN
CI and new unit test, test downloading an image from a saved chart and an unsaved chart
ADDITIONAL INFORMATION
to: @ktmud @graceguo-supercat @suddjian