feat(listviews): SIP-34 filters for charts, dashboards, datasets #10335

nytai · 2020-07-16T01:56:31Z

SUMMARY

api endpoint /api/v1/database/schemas for fetching list of schemas.
adds SIP-34 filters to datasets list view
removes LIST_VIEWS_SIP34_FILTER_UI feature flag
enabled SIP-34 filters for datasts, charts, dashboards, listview
moves src/views/* -> src/views/CRUD/* (eg, src/views/datasetList/DatasetList.tsx -> src/views/CRUD/dataset/DatasetList.tsx ) -- idea being that src/views/CRUD namespace can share code, ie, data fetching logic, state hooks, edit modals, delete modals, etc

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

unit tests pass
can filter on charts, dashboards, datasets list views

ADDITIONAL INFORMATION

Has associated issue:
Changes UI: Behind ENABLE_REACT_CRUD_VIEWS flag
Requires DB Migration.
Confirm DB Migration upgrade and downgrade tested.
Introduces new feature or API
Removes existing feature or API

codecov-commenter · 2020-07-17T00:04:18Z

Codecov Report

Merging #10335 into master will decrease coverage by 0.09%.
The diff coverage is 47.61%.

@@            Coverage Diff             @@
##           master   #10335      +/-   ##
==========================================
- Coverage   70.25%   70.16%   -0.10%     
==========================================
  Files         605      605              
  Lines       32425    32386      -39     
  Branches     3295     3270      -25     
==========================================
- Hits        22781    22724      -57     
- Misses       9535     9553      +18     
  Partials      109      109

Flag	Coverage Δ
#cypress	`54.51% <ø> (-0.01%)`	⬇️
#javascript	`58.90% <28.73%> (-0.37%)`	⬇️
#python	`69.82% <89.74%> (+0.06%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...rc/components/ErrorMessage/TimeoutErrorMessage.tsx	`5.45% <0.00%> (ø)`
superset-frontend/src/components/ListView/utils.ts	`75.00% <ø> (-8.15%)`	⬇️
superset-frontend/src/featureFlags.ts	`100.00% <ø> (ø)`
...uperset-frontend/src/views/CRUD/dataset/Button.tsx	`100.00% <ø> (ø)`
superset-frontend/src/welcome/App.tsx	`0.00% <0.00%> (ø)`
superset/config.py	`90.15% <ø> (ø)`
...et-frontend/src/views/CRUD/dataset/DatasetList.tsx	`61.20% <22.72%> (ø)`
superset-frontend/src/views/CRUD/utils.tsx	`25.00% <25.00%> (ø)`
...perset-frontend/src/views/CRUD/chart/ChartList.tsx	`57.36% <33.33%> (ø)`
...rontend/src/views/CRUD/dashboard/DashboardList.tsx	`64.06% <60.00%> (ø)`
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09dfbab...276f614. Read the comment docs.

bkyryliuk · 2020-07-17T03:35:41Z

can't wait to see it live!

dpgaspar

first pass, couple of comments

dpgaspar · 2020-07-17T18:11:39Z

superset/databases/api.py

+                    page:
+                      type: integer
+                    filter:
+                      type: string


It's nicer to use a reference here to the schema, so we don't have to repeat ourselfs. Take a look at: https://github.com/apache/incubator-superset/blob/master/superset/charts/api.py#L502

dpgaspar · 2020-07-17T18:12:44Z

superset/databases/api.py

+                          value:
+                            type: string
+                          text:
+                            type: string


Here also, declare a marshmallow schema for the response and reference that. Register your schema on OpenAPI using openapi_spec_component_schemas FAB attr

mistercrunch · 2020-07-23T03:37:17Z

This looks amazing, let's get it through!

rusackas

A few little nits/questions, but in general this LGTM! Excited to see these changes!!

superset-frontend/src/views/CRUD/chart/ChartList.tsx

superset-frontend/src/views/CRUD/dataset/DatasetList.tsx

rusackas · 2020-07-24T21:06:26Z

superset-frontend/src/views/CRUD/dataset/DatasetList.tsx

+      endpoint: `${resourceEndpoint}?q=${queryParams}`,
+    });
+
+    return json?.result?.map(


I still get a little excited when I see or use these operators.

superset-frontend/src/views/CRUD/dataset/DatasetList.tsx

superset-frontend/src/views/CRUD/utils.tsx

rusackas · 2020-08-24T18:28:54Z

Impacts #8976

…che#10335)

superset-github-bot bot added the preset-io label Jul 16, 2020

nytai changed the title ~~feature: enabled SIP-34 listview filters for react CRUD~~ feat(listviews): SIP-34 filters for charts, dashboards, datasets Jul 16, 2020

nytai force-pushed the tai/datasets-listview-filters branch from fe39e3f to 86284b4 Compare July 16, 2020 02:29

nytai mentioned this pull request Jul 16, 2020

feat(listviews): SIP-34 Bulk Select #10298

Merged

6 tasks

nytai force-pushed the tai/datasets-listview-filters branch from 437e504 to b44cf7e Compare July 16, 2020 23:57

nytai marked this pull request as ready for review July 17, 2020 00:16

dpgaspar reviewed Jul 17, 2020

View reviewed changes

nytai force-pushed the tai/datasets-listview-filters branch 2 times, most recently from 84f38c3 to b27ae88 Compare July 22, 2020 17:55

nytai requested a review from dpgaspar July 23, 2020 23:51

nytai force-pushed the tai/datasets-listview-filters branch from 64e7136 to 71517d5 Compare July 24, 2020 20:32

nytai added 5 commits July 24, 2020 13:33

move CRUD views to a more semmantic namespace

7756e7e

feat: enabled SIP-34 filters for chart, dashboard, dataset list views

77e2034

fix database filter

14c2020

fix lint

f72d21b

fix: use openapi schemas

31a92de

nytai force-pushed the tai/datasets-listview-filters branch from 71517d5 to c8e89a0 Compare July 24, 2020 20:33

fix import and lint

276f614

nytai force-pushed the tai/datasets-listview-filters branch from c8e89a0 to 276f614 Compare July 24, 2020 21:37

nytai closed this Jul 24, 2020

nytai reopened this Jul 24, 2020

rusackas approved these changes Jul 24, 2020

View reviewed changes

nytai added 3 commits July 24, 2020 16:23

centralize error handling, address PR feedback

06b8d24

fix missed review comment

de98738

lint

e8ef839

nytai merged commit 6f56cd5 into apache:master Jul 27, 2020

nytai deleted the tai/datasets-listview-filters branch July 27, 2020 17:14

auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020

feat(listviews): SIP-34 filters for charts, dashboards, datasets (apa…

1f3a6b0

…che#10335)

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(listviews): SIP-34 filters for charts, dashboards, datasets #10335

feat(listviews): SIP-34 filters for charts, dashboards, datasets #10335

nytai commented Jul 16, 2020

codecov-commenter commented Jul 17, 2020 •

edited

Loading

bkyryliuk commented Jul 17, 2020

dpgaspar left a comment

dpgaspar Jul 17, 2020

dpgaspar Jul 17, 2020

mistercrunch commented Jul 23, 2020 •

edited

Loading

rusackas left a comment

rusackas Jul 24, 2020

rusackas commented Aug 24, 2020

feat(listviews): SIP-34 filters for charts, dashboards, datasets #10335

feat(listviews): SIP-34 filters for charts, dashboards, datasets #10335

Conversation

nytai commented Jul 16, 2020

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

codecov-commenter commented Jul 17, 2020 • edited Loading

Codecov Report

bkyryliuk commented Jul 17, 2020

dpgaspar left a comment

Choose a reason for hiding this comment

dpgaspar Jul 17, 2020

Choose a reason for hiding this comment

dpgaspar Jul 17, 2020

Choose a reason for hiding this comment

mistercrunch commented Jul 23, 2020 • edited Loading

rusackas left a comment

Choose a reason for hiding this comment

rusackas Jul 24, 2020

Choose a reason for hiding this comment

rusackas commented Aug 24, 2020

codecov-commenter commented Jul 17, 2020 •

edited

Loading

mistercrunch commented Jul 23, 2020 •

edited

Loading