Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add TXT as default CSV extension #10371

Merged
merged 1 commit into from
Jul 21, 2020
Merged

feat: add TXT as default CSV extension #10371

merged 1 commit into from
Jul 21, 2020

Conversation

villebro
Copy link
Member

SUMMARY

Currently only CSV and TSV file extensions are supported by default. This adds TXT as a default text file format.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@villebro villebro requested a review from dpgaspar July 21, 2020 07:34
@villebro villebro merged commit 9b8da40 into apache:master Jul 21, 2020
@villebro villebro deleted the villebro/add-txt-to-csv-extensions branch July 22, 2020 21:47
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@villebro @auxten
feat: add TXT as default CSV extension (apache#10371)
c991076
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgaspar dpgaspar dpgaspar approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v0.37 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@villebro @dpgaspar @mistercrunch