chore: wiring ControlLabel to a new FormLabel #10388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating new simple <FormLabel /> component and wiring all <label> and react-bootstrap.ControlLabel towards it. FormLabel becomes a pivotal point that can be altered to point to AntD when we're ready.
Codecov Report
@@ Coverage Diff @@
## master #10388 +/- ##
==========================================
+ Coverage 70.41% 70.45% +0.03%
==========================================
Files 604 605 +1
Lines 32429 32430 +1
Branches 3298 3301 +3
==========================================
+ Hits 22836 22848 +12
+ Misses 9487 9476 -11
Partials 106 106
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ktmud
approved these changes
Jul 23, 2020
There was a problem hiding this comment.
LGTM with one small note.
Also note that form items in Antd normally would just accept label text as an attribute and does not need a Label component. Approving nevertheless for the improved consistency.
| import React, { ReactNode } from 'react'; | ||
| import { ControlLabel } from 'react-bootstrap'; | ||
|
|
||
| interface Props { |
There was a problem hiding this comment.
FormLabelProps would be preferred.
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* chore: wiring ControlLabel to a new FormLabel Creating new simple <FormLabel /> component and wiring all <label> and react-bootstrap.ControlLabel towards it. FormLabel becomes a pivotal point that can be altered to point to AntD when we're ready. * lint * ViewportControl * addressing comments
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating new simple component and wiring all
and react-bootstrap.ControlLabel towards it.
FormLabel becomes a pivotal point that can be altered to point to AntD
when we're ready.