-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dataset editor improvement #10444
feat: dataset editor improvement #10444
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10444 +/- ##
===========================================
- Coverage 70.25% 59.05% -11.20%
===========================================
Files 605 409 -196
Lines 32377 13316 -19061
Branches 3271 3273 +2
===========================================
- Hits 22745 7864 -14881
+ Misses 9522 5263 -4259
- Partials 110 189 +79
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -83,18 +83,23 @@ function ColumnCollectionTable({ | |||
<Field | |||
fieldKey="expression" | |||
label={t('SQL Expression')} | |||
control={<TextControl />} | |||
control={ | |||
<TextAreaControl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looked pretty big in the <tr>
, would look bad if there was many of these stacked... We may want to inline it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update the sql expression field to half the size
45f8a73
to
92e4fa4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - if it LGT @nytai let's merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
TEST PLAN
ADDITIONAL INFORMATION