Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: made BaseScreenshot driver_type configurable #10472

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

JasonD28
Copy link
Contributor

SUMMARY

The webdriver for the BaseScreenshot class was set as a constant to use chromedriver. This PR changes the BaseScreenshot driver_type to default to chrome, but use EMAIL_REPORTS_WEBDRIVER in the config file if it exists.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@bkyryliuk bkyryliuk self-requested a review July 29, 2020 17:33
@bkyryliuk bkyryliuk merged commit c9cb723 into apache:master Jul 30, 2020
JasonD28 added a commit to JasonD28/incubator-superset that referenced this pull request Aug 3, 2020
Co-authored-by: Jason Davis <@dropbox.com>
JasonD28 added a commit to JasonD28/incubator-superset that referenced this pull request Aug 3, 2020
Co-authored-by: Jason Davis <@dropbox.com>
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
Co-authored-by: Jason Davis <@dropbox.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants