build: optimize GitHub Actions for building speed and stability #10485
Conversation
ktmud
requested review from
willbarrett,
craig-rueda,
etr2460 and
john-bodley
and removed request for
willbarrett
| @@ -40,7 +40,7 @@ module.exports = { | |||
| }, | |||
| npm: { | |||
| path: [`${homeDirectory}/.npm`], | |||
| hashFiles: ['superset-frontend/package-lock.json'], | |||
| hashFiles: [`${workspaceDirectory}/superset-frontend/package-lock.json`], | |||
There was a problem hiding this comment.
This cache was disabled but we are keeping the configuration anyway, in case there are other ways to make cache loading faster in the future.
The change here is to make sure we hash the same files wherever the cache step runs.
| local page=$1 | ||
| local group=${2:-Default} | ||
| local cypress="./node_modules/.bin/cypress run" | ||
| local browser=${CYPRESS_BROWSER:-chrome} | ||
|
|
||
| export TERM="xterm" |
| @@ -139,7 +134,7 @@ codecov() { | |||
| local codecovScript="${HOME}/codecov.sh" | |||
| # download bash script if needed | |||
| if [[ ! -f "$codecovScript" ]]; then | |||
| curl -s https://codecov.io/bash > "$codecovScript" | |||
| curl -s https://codecov.io/bash >"$codecovScript" | |||
There was a problem hiding this comment.
automatically reformatted by Prettier
| build-assets | ||
| cache-save assets | ||
| fi | ||
| } |
There was a problem hiding this comment.
Clean up a unused function
Codecov Report
@@ Coverage Diff @@
## master #10485 +/- ##
=======================================
Coverage 70.80% 70.80%
=======================================
Files 604 604
Lines 32426 32426
Branches 3414 3414
=======================================
Hits 22960 22960
Misses 9354 9354
Partials 112 112
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
As a side note it would be good to couple these GitHub workflows with tox so users can run the same CI checks locally in a consistent manner.
I find local CI vital for test iteration, typing, linting, etc. Note I plan to couple pre-commit more tightly with tox to future reduce repetition and ensure consistency.
mistercrunch
added
🏷️ bot
SUMMARY
Here is an example of a successful run when the record key is properly configured.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
Make sure CI passes
ADDITIONAL INFORMATION