fix: support non-string groupbys for pie chart #10493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
villebro
changed the title
ktmud
approved these changes
Jul 31, 2020
ktmud
reviewed
Jul 31, 2020
tests/viz_tests.py
Outdated
| base_df = pd.DataFrame( | ||
| data={ | ||
| "intcol": [1, 2, 3, 4], | ||
| "floatcol": [0.1, 0.2, 0.3, 0.4], |
There was a problem hiding this comment.
Would it help to insert a couple of Nones in these columns as well? And maybe add a boolean column, too?
There was a problem hiding this comment.
Good catch, numeric nulls were not properly handled (showed up as nan), adding tests.
villebro
changed the title
villebro
force-pushed
the
villebro/pie-chart-tests
branch
from
ac69124
to
7a08776
Compare
villebro
force-pushed
the
villebro/pie-chart-tests
branch
from
7a08776
to
e40cf91
Compare
JasonD28
pushed a commit
to JasonD28/incubator-superset
that referenced
this pull request
Aug 3, 2020
* chore: add unit tests to pie chart * refine logic for floats and nans and add more tests
villebro
added a commit
to preset-io/superset
that referenced
this pull request
Aug 20, 2020
* chore: add unit tests to pie chart * refine logic for floats and nans and add more tests
craig-rueda
pushed a commit
to preset-io/superset
that referenced
this pull request
Aug 24, 2020
* chore: add unit tests to pie chart * refine logic for floats and nans and add more tests
villebro
added a commit
that referenced
this pull request
Sep 5, 2020
* chore: add unit tests to pie chart * refine logic for floats and nans and add more tests
villebro
added a commit
that referenced
this pull request
Sep 16, 2020
* chore: add unit tests to pie chart * refine logic for floats and nans and add more tests
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* chore: add unit tests to pie chart * refine logic for floats and nans and add more tests
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* chore: add unit tests to pie chart * refine logic for floats and nans and add more tests
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This adds support for non-string labels to the Pie Chart Viz and uses
NULL_STRINGif a pie label isNone. Also removes decimals for float groupbys that satisfyis_integer(). This is needed, as allintcolumns becomefloatif they containNULLs (Pandas limitation).BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
CI + new tests + local testing
ADDITIONAL INFORMATION