fix: make SQL-based alert email links user friendly #10519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 4, 2020 14:33
JasonD28
commented
Aug 4, 2020
| @@ -580,13 +580,15 @@ def deliver_alert(alert_id: int, recipients: Optional[str] = None) -> None: | |||
| "Superset.slice", slice_id=alert.slice.id, standalone="true" | |||
| ) | |||
| screenshot = ChartScreenshot(chart_url, alert.slice.digest) | |||
| cache_key = screenshot.cache_key() | |||
| image_url = get_url_path( | |||
There was a problem hiding this comment.
image_url was never being used, it was just being replaced at https://github.com/apache/incubator-superset/blob/bdfabc23e7b1474c164a55defa4957a027d2b147/superset/tasks/schedules.py#L587-L589
bkyryliuk
approved these changes
Aug 4, 2020
Ofeknielsen
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Oct 5, 2020
* make urls user friendly * formatting Co-authored-by: Jason Davis <@dropbox.com>
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* make urls user friendly * formatting Co-authored-by: Jason Davis <@dropbox.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The links in SQL-based alert emails were not user friendly, i.e.
local:####/superset. This PR makes the links user friendly based onWEBDRIVER_BASEURL_USER_FRIENDLYin config.pyBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION