Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolves #10535 -> unable to run tox testing #10536

Merged
merged 2 commits into from
Aug 10, 2020

Conversation

john-bodley
Copy link
Member

SUMMARY

Resolves #10535.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

Ran tox -e py37 locally.

ADDITIONAL INFORMATION

  • Has associated issue: Unable to run tox testing #10535
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2020

Codecov Report

Merging #10536 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10536      +/-   ##
==========================================
- Coverage   63.70%   63.56%   -0.14%     
==========================================
  Files         767      767              
  Lines       36283    36274       -9     
  Branches     3430     3430              
==========================================
- Hits        23115    23059      -56     
- Misses      13054    13101      +47     
  Partials      114      114              
Flag Coverage Δ
#cypress 54.39% <ø> (+0.06%) ⬆️
#javascript 59.88% <ø> (ø)
#python 59.07% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/presto.py 70.56% <0.00%> (-12.14%) ⬇️
superset/views/database/mixins.py 80.70% <0.00%> (-1.76%) ⬇️
superset/models/core.py 87.22% <0.00%> (-0.28%) ⬇️
superset/connectors/sqla/models.py 89.04% <0.00%> (-0.15%) ⬇️
superset/sql_parse.py 99.30% <0.00%> (-0.01%) ⬇️
superset/errors.py 100.00% <0.00%> (ø)
superset/viz_sip38.py 0.00% <0.00%> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js 62.60% <0.00%> (ø)
...rontend/src/SqlLab/components/QueryAutoRefresh.jsx 72.72% <0.00%> (+6.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a908d4...04f812d. Read the comment docs.

@mistercrunch mistercrunch changed the title fix: Resolves #10535 fix: Resolves #10535 -> unable to run tox testing Aug 7, 2020
@john-bodley john-bodley merged commit 5e944e5 into apache:master Aug 10, 2020
Ofeknielsen pushed a commit to ofekisr/incubator-superset that referenced this pull request Oct 5, 2020
Co-authored-by: John Bodley <john.bodley@airbnb.com>
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
Co-authored-by: John Bodley <john.bodley@airbnb.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to run tox testing
6 participants