Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add translate for dropdown menu #10573

Merged
merged 2 commits into from
Aug 11, 2020
Merged

fix: add translate for dropdown menu #10573

merged 2 commits into from
Aug 11, 2020

Conversation

stuarthu
Copy link

@stuarthu stuarthu commented Aug 11, 2020 •
edited
Loading

SUMMARY

Add translate for dropdown menu

BEFORE

截屏2020-08-11 15 28 43

AFTER

截屏2020-08-11 16 18 21

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

fix: translate dropdown menu
e7d95c9 
Signed-off-by: Stuart Hu <shijiehu@improbable.io>
@codecov-commenter
Copy link

Codecov Report

Merging #10573 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10573      +/-   ##
==========================================
+ Coverage   63.87%   63.89%   +0.01%     
==========================================
  Files         767      767              
  Lines       36301    36315      +14     
  Branches     3430     3431       +1     
==========================================
+ Hits        23186    23202      +16     
+ Misses      13002    13000       -2     
  Partials      113      113
Flag Coverage Δ
#cypress 54.37% <ø> (+0.05%) ⬆️
#javascript 59.87% <ø> (-0.03%) ⬇️
#python 59.57% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/postgres.py 97.43% <0.00%> (-2.57%) ⬇️
superset-frontend/src/chart/ChartRenderer.jsx 75.34% <0.00%> (-0.34%) ⬇️
superset-frontend/src/chart/Chart.jsx 58.18% <0.00%> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js 62.60% <0.00%> (ø)
...tend/src/dashboard/containers/DashboardBuilder.jsx 100.00% <0.00%> (ø)
...nd/src/dashboard/containers/DashboardComponent.jsx 100.00% <0.00%> (ø)
...tend/src/dashboard/components/DashboardBuilder.jsx 84.84% <0.00%> (+0.47%) ⬆️
superset/db_engine_specs/presto.py 82.69% <0.00%> (+0.67%) ⬆️
...-frontend/src/dashboard/reducers/dashboardState.js 81.81% <0.00%> (+0.68%) ⬆️
...t-frontend/src/dashboard/actions/dashboardState.js 58.82% <0.00%> (+0.82%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 613dd12...e7d95c9. Read the comment docs.

@mistercrunch mistercrunch added the i18n Namespace | Anything related to localization label Aug 11, 2020
iriswonderland13
iriswonderland13 approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@iriswonderland13 iriswonderland13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated translation of "Edit Chart Metadata" to make it more concrete. Otherwise the translation looks great!

superset/translations/zh/LC_MESSAGES/messages.json Outdated Show resolved Hide resolved
superset/translations/zh/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
@iriswonderland13
Apply suggestions from code review
2686361 
Co-authored-by: iriswonderland13 <69527796+iriswonderland13@users.noreply.github.com>
etr2460
etr2460 approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the translations!

@etr2460 etr2460 merged commit 890b3ca into apache:master Aug 11, 2020
@stuarthu stuarthu deleted the translate2 branch August 12, 2020 01:35
Ofeknielsen pushed a commit to ofekisr/incubator-superset that referenced this pull request Oct 5, 2020
@iriswonderland13
fix: add translate for dropdown menu (apache#10573)
f210728 
* fix: translate dropdown menu

Signed-off-by: Stuart Hu <shijiehu@improbable.io>

* Apply suggestions from code review

Co-authored-by: iriswonderland13 <69527796+iriswonderland13@users.noreply.github.com>

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
Co-authored-by: iriswonderland13 <69527796+iriswonderland13@users.noreply.github.com>
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@iriswonderland13 @auxten
fix: add translate for dropdown menu (apache#10573)
3734078 
* fix: translate dropdown menu

Signed-off-by: Stuart Hu <shijiehu@improbable.io>

* Apply suggestions from code review

Co-authored-by: iriswonderland13 <69527796+iriswonderland13@users.noreply.github.com>

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
Co-authored-by: iriswonderland13 <69527796+iriswonderland13@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iriswonderland13 iriswonderland13 iriswonderland13 approved these changes

@etr2460 etr2460 etr2460 approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels i18n Namespace | Anything related to localization size/M 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stuarthu @codecov-commenter @etr2460 @iriswonderland13 @mistercrunch