Add cache warmup endpoint #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def get_viz(self, url_params_multidict=None): | ||
| """Creates BaseViz object from the url_params_multidict. | ||
|
|
||
| Parameters |
There was a problem hiding this comment.
If we want to auto generate docs for the code we should stick with Sphinx's (the documentation framework we use) way of specifying docstrings:
http://www.sphinx-doc.org/en/stable/domains.html#info-field-lists
|
Nice. A few minor nits but the code looks much better overall! |
|
Oh looks like this PR is a superset of #1062 isn't it? I won't review 1062 if that's the case. |
|
@mistercrunch - yes. I wasn't sure how stack the PRs on top of each other here. |
|
LGTM! |
|
thanks @mistercrunch for the review! |
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the FR: #1021
Based on the PR: #1062
This PR adds 2 types of the cache warm up endpoints:
/caravel/warm_up_cache?table_name=energy_usage&db_name=main