feat: use shorten url in standalone iframe #10651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graceguo-supercat
changed the title
graceguo-supercat
force-pushed
the
gg-ShorternIframeLink
branch
from
63eca23 to
cfcef3f
Compare
graceguo-supercat
changed the title
mistercrunch
approved these changes
Aug 21, 2020
6 tasks
villebro
pushed a commit
that referenced
this pull request
Sep 11, 2020
Ofeknielsen
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Oct 5, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Superset's chart has "standalone" mode, and also offers a button to generate code to embed standalone chart in an iframe. But sometimes the chart full url is too long that nginx server (depends on company's infrastructure setup) can't handle it, and user can't use this iframe code.
This PR is to improve this standalone chart link. Instead of using full url, we can use shorten link.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TEST PLAN
CI and manual test
ADDITIONAL INFORMATION