Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: card view cypress failed tests #10699

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

lilykuang
Copy link
Member

SUMMARY

  • quick fix for failed cypress tests on chart and dashboard CRUD card view

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

Codecov Report

Merging #10699 into master will increase coverage by 0.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10699      +/-   ##
==========================================
+ Coverage   60.65%   61.35%   +0.69%     
==========================================
  Files         786      426     -360     
  Lines       36979    13788   -23191     
  Branches     3533     3533              
==========================================
- Hits        22430     8459   -13971     
+ Misses      14362     5142    -9220     
  Partials      187      187              
Flag Coverage Δ
#javascript 61.35% <ø> (ø)
#python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/dashboards/commands/delete.py
superset/models/sql_types/presto_sql_types.py
superset/views/chart/views.py
superset/commands/utils.py
...6819ee0e3_fix_wrong_constraint_on_table_columns.py
...ersions/cca2f5d568c8_add_encrypted_extra_to_dbs.py
superset/datasets/commands/refresh.py
superset/migrations/versions/fc480c87706c_.py
superset/migrations/versions/4736ec66ce19_.py
...ations/versions/130915240929_is_sqllab_viz_flow.py
... and 350 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d94534...8a06a9d. Read the comment docs.

@bkyryliuk
Copy link
Member

thank you!

@nytai nytai merged commit 7abdf53 into apache:master Aug 27, 2020
@nytai nytai deleted the lily/card-view-cypress-e2e branch August 27, 2020 18:33
Ofeknielsen pushed a commit to ofekisr/incubator-superset that referenced this pull request Oct 5, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants