Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move menu reorg logic from crud app into Menu component #10717

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

nytai
Copy link
Member

@nytai nytai commented Aug 28, 2020

SUMMARY

Recently a PR was merged that reorganized some of the menu options into a settings dropdown. That logic was only applied to one of the react "apps" https://github.com/preset-io/incubator-superset/blob/3e374dab076ae8baeab6148203ed1a74d1627a59/superset-frontend/src/views/App.tsx#L66

This PR moves that logic into the menu component so that all instances of the menu have the same reorg applied.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screen Shot 2020-08-28 at 10 55 50 AM

After:
Screen Shot 2020-08-28 at 10 56 13 AM

TEST PLAN

  • 👀 (this changes can be seen in sqllab, on master there's a Security and Manage dropdown, on this branch, those options live under the settings dropdown)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2020

Codecov Report

Merging #10717 into master will decrease coverage by 4.82%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10717      +/-   ##
==========================================
- Coverage   64.93%   60.11%   -4.83%     
==========================================
  Files         789      360     -429     
  Lines       37122    23222   -13900     
  Branches     3555        0    -3555     
==========================================
- Hits        24107    13959   -10148     
+ Misses      12908     9263    -3645     
+ Partials      107        0     -107     
Flag Coverage Δ
#cypress ?
#javascript ?
#python 60.11% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/presto.py 73.54% <0.00%> (-8.75%) ⬇️
superset/examples/world_bank.py 97.10% <0.00%> (-2.90%) ⬇️
superset/examples/birth_names.py 97.36% <0.00%> (-2.64%) ⬇️
superset/models/core.py 87.77% <0.00%> (-0.28%) ⬇️
superset/connectors/sqla/models.py 89.58% <0.00%> (-0.14%) ⬇️
...nd/src/dashboard/components/gridComponents/Tab.jsx
superset-frontend/src/views/CRUD/hooks.ts
...et-frontend/src/explore/controlPanels/DeckMulti.js
...d/src/dashboard/util/getLeafComponentIdFromPath.js
...t-frontend/src/SqlLab/components/ColumnElement.tsx
... and 422 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e374da...2e8b64a. Read the comment docs.

@nytai nytai merged commit d3bdea3 into apache:master Aug 28, 2020
@nytai nytai deleted the tai/fix-menu-reorg branch August 28, 2020 20:56
@villebro villebro added v0.38 and removed v0.38 labels Sep 10, 2020
Ofeknielsen pushed a commit to ofekisr/incubator-superset that referenced this pull request Oct 5, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants