-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move menu reorg logic from crud app into Menu component #10717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nytai
force-pushed
the
tai/fix-menu-reorg
branch
from
August 28, 2020 18:11
cfb02dc
to
2e8b64a
Compare
Codecov Report
@@ Coverage Diff @@
## master #10717 +/- ##
==========================================
- Coverage 64.93% 60.11% -4.83%
==========================================
Files 789 360 -429
Lines 37122 23222 -13900
Branches 3555 0 -3555
==========================================
- Hits 24107 13959 -10148
+ Misses 12908 9263 -3645
+ Partials 107 0 -107
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nytai
force-pushed
the
tai/fix-menu-reorg
branch
from
August 28, 2020 18:24
2e8b64a
to
6d54cd8
Compare
mistercrunch
approved these changes
Aug 28, 2020
nytai
force-pushed
the
tai/fix-menu-reorg
branch
from
August 28, 2020 18:34
6d54cd8
to
6e26822
Compare
nytai
force-pushed
the
tai/fix-menu-reorg
branch
from
August 28, 2020 18:40
6e26822
to
dafc1e8
Compare
rusackas
approved these changes
Aug 28, 2020
Ofeknielsen
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Oct 5, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
🚢 0.38.0
labels
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Recently a PR was merged that reorganized some of the menu options into a settings dropdown. That logic was only applied to one of the react "apps" https://github.com/preset-io/incubator-superset/blob/3e374dab076ae8baeab6148203ed1a74d1627a59/superset-frontend/src/views/App.tsx#L66
This PR moves that logic into the menu component so that all instances of the menu have the same reorg applied.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
ADDITIONAL INFORMATION