Fix: Rejiggering some dependencies, trying to get CI to pass

[rusackas]

SUMMARY

npm install pointed out these duplicated dependencies. Just cleaning up and hoping CI runs.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[etr2460]

lgtm, although i've never known if @types requirements should be in dependencies or devDependencies. We should probably be consistent (especially since i'm sure @types/enzyme isn't needed for the production app)

[rusackas]

lgtm, although i've never known if @types requirements should be in dependencies or devDependencies. We should probably be consistent (especially since i'm sure @types/enzyme isn't needed for the production app)

I keep wondering the same thing... then I google around to see what others say/do, and wind up just as confused :P

I'm also unsure about the fsevents optional dependency. I just made it e dependency for now, and it seems to be working.

I'm trying not to rock the boat too hard on this PR, but once this goes in, I'll open subsequent PRs to remove fsevents and move @types to devDependencies, and see how those play out.

[codecov-commenter]

Codecov Report

Merging #10747 into master will increase coverage by 4.77%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10747      +/-   ##
==========================================
+ Coverage   60.28%   65.06%   +4.77%     
==========================================
  Files         360      789     +429     
  Lines       23223    37179   +13956     
  Branches        0     3555    +3555     
==========================================
+ Hits        14001    24192   +10191     
- Misses       9222    12882    +3660     
- Partials        0      105     +105     

Flag	Coverage Δ
#cypress	56.15% <ø> (?)
#javascript	61.49% <ø> (?)
#python	60.29% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/db_engines/hive.py	82.14% <0.00%> (-3.58%)	⬇️
...explore/components/AdhocMetricEditPopoverTitle.jsx	84.61% <0.00%> (ø)
...ontend/src/dashboard/util/getDashboardFilterKey.ts	100.00% <0.00%> (ø)
superset-frontend/src/setup/setupClient.js	80.00% <0.00%> (ø)
...et-frontend/src/SqlLab/components/TableElement.jsx	82.75% <0.00%> (ø)
superset-frontend/src/logger/actions/index.js	100.00% <0.00%> (ø)
...c/dashboard/components/gridComponents/Markdown.jsx	89.01% <0.00%> (ø)
superset-frontend/src/SqlLab/reducers/common.js	100.00% <0.00%> (ø)
superset-frontend/src/chart/ChartContainer.jsx	100.00% <0.00%> (ø)
...rset-frontend/src/dashboard/actions/datasources.js	57.89% <0.00%> (ø)
... and 421 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd144b6...546ed5e. Read the comment docs.