[sql-lab] ui polish #1079
Merged
[sql-lab] ui polish #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 7, 2016 23:21
- prevent default on accordion clicks - always show table actions, they are more discoverable like that - polish spacing/layout
| <span className="pull-left m-l-5">{col.name}</span> | ||
| <span className="pull-right text-muted">{col.type}</span> | ||
| <div className="row"> | ||
| <div className="col-sm-8"> |
There was a problem hiding this comment.
I prefer having the pull-left pull-right there. Long table names will overflow in unoptimal and inconsistent ways depending on window size.
There was a problem hiding this comment.
ok good point, will change this back.
There was a problem hiding this comment.
discussed and the browser size that using the grid here would pose a problem at is basically tablet size, and we haven't designed for the breakpoint anywhere else yet.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
---prevent default on accordion clicks
--- always show table actions, they are more discoverable like that
--- polish spacing/layout
table-condensed)before:
after:
plz review @mistercrunch @bkyryliuk @vera-liu