Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: database delete warning #10800

Merged
merged 1 commit into from
Sep 9, 2020
Merged

feat: database delete warning #10800

merged 1 commit into from
Sep 9, 2020

Conversation

nytai
Copy link
Member

@nytai nytai commented Sep 4, 2020 •
edited
Loading

SUMMARY

  • api endpoint to fetch charts and dashboards related to a database
  • warning modal to display message regarding potential effects of deleting a database

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2020-09-04 at 4 21 39 PM

Screen Shot 2020-09-04 at 4 21 22 PM

Screen Shot 2020-09-04 at 4 23 22 PM

TEST PLAN

  • CI, py and js test, 👀

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI (behding ENABLE_REACT_CRUD_VIEWS config and SIP_34_DATABASE_UI feature flag)
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@nytai nytai marked this pull request as ready for review September 8, 2020 16:48
@nytai nytai merged commit 50672bb into apache:master Sep 9, 2020
@nytai nytai deleted the tai/database-delete-warn branch September 9, 2020 01:54
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@nytai @auxten
feat: database delete warning (apache#10800)
642aac3
@benceorlai
Copy link

Roadmap: apache-superset/superset-roadmap#55

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willbarrett willbarrett willbarrett approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nytai @benceorlai @willbarrett @mistercrunch