Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(databases): test connection api endpoint #10824

Merged
merged 3 commits into from
Sep 10, 2020
Merged

fix(databases): test connection api endpoint #10824

merged 3 commits into from
Sep 10, 2020

Conversation

lilykuang
Copy link
Member

SUMMARY

  • fix extra field format for test connection api endpoint

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

dpgaspar
dpgaspar reviewed Sep 10, 2020
View reviewed changes
Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment and lint is failing

superset/databases/schemas.py Outdated
description=encrypted_extra_description, validate=encrypted_extra_validator
description=encrypted_extra_description,
validate=encrypted_extra_validator,
allow_none=True,
)
server_cert = fields.String(
description=server_cert_description, validate=server_cert_validator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably need allow_none=True for server_cert also

@lilykuang lilykuang requested a review from dpgaspar September 10, 2020 16:45
dpgaspar
dpgaspar reviewed Sep 10, 2020
View reviewed changes
Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be awesome if you could add a couple of simple tests that assert this fix is useful server_cert=null etc..

@dpgaspar dpgaspar merged commit f0545bf into apache:master Sep 10, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@auxten
fix(databases): test connection api endpoint (apache#10824)
1fb00bc 
* fix test connection with extra

* fix lint and allow_none server_cert

* update test connection tests
@lilykuang lilykuang deleted the lily/test-connection-fix branch December 2, 2020 18:54
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riahk riahk riahk approved these changes

@dpgaspar dpgaspar dpgaspar approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lilykuang @dpgaspar @riahk @mistercrunch