Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Adding table comment and columns comment for SQLLab #10844

Merged
merged 6 commits into from
Sep 15, 2020
Merged

Feat: Adding table comment and columns comment for SQLLab #10844

merged 6 commits into from
Sep 15, 2020

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

adding table comment and columns comment for SQLLab

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@ktmud
Copy link
Member

ktmud commented Sep 11, 2020 •
edited
Loading

Do you mind fixing the CI (simply run black superset/) and sharing a little bit how may this be used in the UI?

@zhaoyongjie
Copy link
Member Author

zhaoyongjie commented Sep 12, 2020 •
edited
Loading

@ktmud

for columns comment:

I plan to add a comment label closed to each column, similar to the current index icon, and then when there is a comment in this column, the "Comment ICON" will be displayed and the comment will be displayed in the popover/modal

for table comment:

Similar to the column display. Add a table comment icon beside the table name text

image

mistercrunch
mistercrunch requested changes Sep 13, 2020
View reviewed changes
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, otherwise LGTM. About the frontend changes, I think an "info bubble" with a tooltip on the right side of the table name would work well here.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 14, 2020
@zhaoyongjie zhaoyongjie reopened this Sep 15, 2020
@mistercrunch
Copy link
Member

super

@mistercrunch mistercrunch merged commit 38edb69 into apache:master Sep 15, 2020
@zhaoyongjie zhaoyongjie deleted the add_table_and_columns_comment branch September 21, 2020 14:42
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@zhaoyongjie @auxten
Feat: Adding table comment and columns comment for SQLLab (apache#10844)
d62c9e2 
* Adding table comment and columns comment for backend

* fix mypy

* Fix CI

* adding wider catch

* use logger

* fix lint
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

@dpgaspar dpgaspar Awaiting requested review from dpgaspar

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhaoyongjie @ktmud @mistercrunch