Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: superset alerting misc fixes #10891

Merged
merged 2 commits into from
Sep 16, 2020
Merged

fix: superset alerting misc fixes #10891

merged 2 commits into from
Sep 16, 2020

Conversation

bkyryliuk
Copy link
Member

@bkyryliuk bkyryliuk commented Sep 15, 2020 •
edited
Loading

SUMMARY

  • removed logs & other stuff from the alert view
  • change created by to the owner in the alert view
  • changed alert & observation log sorting by date desc
  • show validator config in the list
  • 0 results doesn't work in the validation: link

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image
image

After:
image
image

TEST PLAN

  • unit tests
  • local
  • dropbox staging

@bkyryliuk bkyryliuk changed the title fix: superset alerting misc fixes fix: superset alerting misc fixes [WIP] Sep 15, 2020
@bkyryliuk bkyryliuk marked this pull request as draft September 15, 2020 16:55
@bkyryliuk bkyryliuk force-pushed the bogdan/alerting_fixes branch 3 times, most recently from cecfd46 to 8931466 Compare September 15, 2020 19:13
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2020 •
edited
Loading

Codecov Report

Merging #10891 into master will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10891      +/-   ##
==========================================
+ Coverage   59.15%   59.32%   +0.17%     
==========================================
  Files         778      778              
  Lines       37123    37103      -20     
  Branches     3310     3310              
==========================================
+ Hits        21959    22013      +54     
+ Misses      14973    14904      -69     
+ Partials      191      186       -5
Flag Coverage Δ
#cypress 55.34% <ø> (+0.44%) ⬆️
#python 61.47% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/models/alerts.py 96.84% <100.00%> (+0.03%) ⬆️
superset/tasks/alerts/validator.py 95.23% <100.00%> (-0.12%) ⬇️
superset/tasks/schedules.py 76.80% <100.00%> (-0.07%) ⬇️
superset/views/alerts.py 84.41% <100.00%> (+10.45%) ⬆️
superset/db_engine_specs/presto.py 82.28% <0.00%> (+0.67%) ⬆️
...rontend/src/SqlLab/components/AceEditorWrapper.tsx 52.43% <0.00%> (+1.21%) ⬆️
superset-frontend/src/SqlLab/reducers/sqlLab.js 12.86% <0.00%> (+1.65%) ⬆️
...end/src/SqlLab/components/TemplateParamsEditor.jsx 91.42% <0.00%> (+2.85%) ⬆️
...erset-frontend/src/SqlLab/components/SqlEditor.jsx 49.09% <0.00%> (+3.03%) ⬆️
superset-frontend/src/components/TableSelector.jsx 52.94% <0.00%> (+3.26%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c420d6...8931466. Read the comment docs.

@bkyryliuk bkyryliuk marked this pull request as ready for review September 15, 2020 20:31
@bkyryliuk bkyryliuk changed the title fix: superset alerting misc fixes [WIP] fix: superset alerting misc fixes Sep 15, 2020
@willbarrett
Copy link
Member

Let's get some tests around these fixes.

@bkyryliuk bkyryliuk force-pushed the bogdan/alerting_fixes branch from 8931466 to f243e99 Compare September 16, 2020 16:09
@bkyryliuk
Copy link
Member Author

Let's get some tests around these fixes.

good reminder :) added the test

@bkyryliuk bkyryliuk merged commit c3f1720 into apache:master Sep 16, 2020
@bkyryliuk bkyryliuk deleted the bogdan/alerting_fixes branch September 16, 2020 18:09
mistercrunch added a commit that referenced this pull request Oct 2, 2020
@mistercrunch
Revert "fix: superset alerting misc fixes (#10891)"
0df21d8 
This reverts commit c3f1720.
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@bkyryliuk @bogdan-dbx @auxten
fix: superset alerting misc fixes (apache#10891)
3198027 
* Superset alerting misc fixes

* Test 0 threshold

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch
Revert "fix: superset alerting misc fixes (apache#10891)"
bea2d46 
This reverts commit 7d09e4d.
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch Awaiting requested review from mistercrunch

@willbarrett willbarrett Awaiting requested review from willbarrett

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bkyryliuk @codecov-commenter @willbarrett @mistercrunch @bogdan-dbx