Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cypress): prevent CI failure on codecov failure #10892

Merged
merged 1 commit into from
Sep 15, 2020
Merged

fix(cypress): prevent CI failure on codecov failure #10892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/bashlib.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,8 @@ cypress-run-all() {

# Upload code coverage separately so each page can have separate flags
# -c will clean existing coverage reports, -F means add flags
codecov -cF "cypress"
# || true to prevent CI failure on codecov upload
codecov -cF "cypress" || true

# After job is done, print out Flask log for debugging
say "::group::Flask log for default run"
Expand All @@ -205,7 +206,9 @@ cypress-run-all() {
local flaskProcessId=$!

cypress-run "sqllab/*" "Backend persist"
codecov -cF "cypress"

# || true to prevent CI failure on codecov upload
codecov -cF "cypress" || true

say "::group::Flask log for backend persist"
cat "$flasklog"
Expand Down