Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: babel script broken by format string #10902

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

babel script broken by format string, runing after translation script

 flask fab babel-extract --target superset/translations --output superset/translations/messages.pot --config superset/translations/babel.cfg -k _ -k __ -k t -k tn -k tct

raise bable exception

image

TEST PLAN

Do we need a tox task to add the translation testing? @mistercrunch

@rusackas
Copy link
Member

Open question to @mistercrunch but this change LGTM.

@rusackas rusackas merged commit 5099dbe into apache:master Sep 16, 2020
@nytai
Copy link
Member

nytai commented Sep 16, 2020

We have CI checks for translation, I'm surprised this wasn't caught by those.

https://github.com/apache/incubator-superset/runs/1121177228

@zhaoyongjie zhaoyongjie deleted the fix_babel_break branch September 21, 2020 14:42
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants