Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jinja): make context attrs private on SQL templates #10934

Merged
merged 3 commits into from
Sep 18, 2020

Conversation

dpgaspar
Copy link
Member

SUMMARY

Make Jinja Context class attributes private

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpgaspar dpgaspar merged commit e375ed4 into apache:master Sep 18, 2020
@dpgaspar dpgaspar deleted the fix/engine-templates branch September 18, 2020 11:56
@dpgaspar dpgaspar added the v0.38 label Sep 21, 2020
villebro pushed a commit that referenced this pull request Sep 21, 2020
* fix(jinja): make SQLAlchemy models private on SQL templates

* add missing privates

* fix test
etr2460 pushed a commit to airbnb/superset-fork that referenced this pull request Sep 21, 2020
* fix(jinja): make SQLAlchemy models private on SQL templates

* add missing privates

* fix test
dpgaspar added a commit that referenced this pull request Sep 22, 2020
* fix(jinja): make SQLAlchemy models private on SQL templates

* add missing privates

* fix test
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
* fix(jinja): make SQLAlchemy models private on SQL templates

* add missing privates

* fix test
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* fix(jinja): make SQLAlchemy models private on SQL templates

* add missing privates

* fix test
@mistercrunch mistercrunch added 🍒 0.37.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v0.37 v0.37.2 v0.38 🍒 0.37.2 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants