create structure for new forked explore view #1099
Merged
+113
−330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import ExploreViewContainer from './components/ExploreViewContainer'; | ||
|
|
||
| const exploreViewContainer = document.getElementById('js-explore-view-container'); | ||
| const bootstrapData = exploreViewContainer.getAttribute('data-bootstrap'); |
There was a problem hiding this comment.
@vera-liu this is what i was thinking for bootstrapping the data from the server to the client.
we need to fix the formatting of bootstrapData either in js or python since this is not quite well formed json yet, but it gives you the idea.
ascott
changed the title
|
Yayyyyyyyyyyy so psyched for this! On Tuesday, September 13, 2016, Alanna Scott notifications@github.com
Chris Williams Data Visualization |
vera-liu
pushed a commit
to vera-liu/caravel
that referenced
this pull request
Sep 27, 2016
* create structure for new forked explore view * update component name * add bootstrap data pattern * remove console.log
vera-liu
added a commit
that referenced
this pull request
Sep 29, 2016
…1205) * create structure for new forked explore view (#1099) * create structure for new forked explore view * update component name * add bootstrap data pattern * remove console.log * Associate version to entry files (#1060) * Associate version to entry files * Modified path joins for configs * Made changes based on comments * Created store and reducers (#1108) * Created store and reducers * Added spec * Modifications based on comments * Explore control panel components: Chart control, Time filter, SQL, GroupBy and Filters * Modifications based on comments
ascott
pushed a commit
that referenced
this pull request
Oct 4, 2016
* Explore control panel - Chart control, TimeFilter, GroupBy, Filters (#1205) * create structure for new forked explore view (#1099) * create structure for new forked explore view * update component name * add bootstrap data pattern * remove console.log * Associate version to entry files (#1060) * Associate version to entry files * Modified path joins for configs * Made changes based on comments * Created store and reducers (#1108) * Created store and reducers * Added spec * Modifications based on comments * Explore control panel components: Chart control, Time filter, SQL, GroupBy and Filters * Modifications based on comments * accommodate old and new explore urls * move bootstrap data up in scope * fix code climate issues * fix long lines * fix syntax error
vera-liu
added a commit
to vera-liu/caravel
that referenced
this pull request
Oct 4, 2016
…pache#1205) * create structure for new forked explore view (apache#1099) * create structure for new forked explore view * update component name * add bootstrap data pattern * remove console.log * Associate version to entry files (apache#1060) * Associate version to entry files * Modified path joins for configs * Made changes based on comments * Created store and reducers (apache#1108) * Created store and reducers * Added spec * Modifications based on comments * Explore control panel components: Chart control, Time filter, SQL, GroupBy and Filters * Modifications based on comments
vera-liu
added a commit
that referenced
this pull request
Oct 4, 2016
* Explore control panel - Chart control, TimeFilter, GroupBy, Filters (#1205) * create structure for new forked explore view (#1099) * create structure for new forked explore view * update component name * add bootstrap data pattern * remove console.log * Associate version to entry files (#1060) * Associate version to entry files * Modified path joins for configs * Made changes based on comments * Created store and reducers (#1108) * Created store and reducers * Added spec * Modifications based on comments * Explore control panel components: Chart control, Time filter, SQL, GroupBy and Filters * Modifications based on comments * Added access check + Druid in endpoint * pull grains to constants * Switch explore.html to old version
vera-liu
added a commit
to vera-liu/caravel
that referenced
this pull request
Oct 4, 2016
…pache#1205) * create structure for new forked explore view (apache#1099) * create structure for new forked explore view * update component name * add bootstrap data pattern * remove console.log * Associate version to entry files (apache#1060) * Associate version to entry files * Modified path joins for configs * Made changes based on comments * Created store and reducers (apache#1108) * Created store and reducers * Added spec * Modifications based on comments * Explore control panel components: Chart control, Time filter, SQL, GroupBy and Filters * Modifications based on comments
ascott
pushed a commit
that referenced
this pull request
Oct 6, 2016
* create structure for new forked explore view (#1099) * create structure for new forked explore view * update component name * add bootstrap data pattern * remove console.log * Created store and reducers (#1108) * Created store and reducers * Added spec * Modifications based on comments * do use bootstrap data for now * don't deal with bootstrap data for now * use victory as a base * import fake line data, add fake panels, make chart fixed * add fetch support * get slice data from json endpoint * render chart with slicejson * update chart and label demo * remove fetch config * remove dummy control panels * should be a func * make TimeSeriesLineChart * add a comment * inner height for height * don't need fetch yet * trailing comma breaks in package json * pass in viz data from props * add style sheet * set height on explore container * add legend * make chart responsive to window resize * can't use head_css in template bc overrides head_css in basic * fix linting * break labelItem into own SFC, make legend SFC * add propTypes and fix linter
This was referenced Jun 2, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
* fix(plugin-chart-echarts): add orderby fix apache#14534 * feat(plugin-chart-echarts): set orderby default value is true
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
* fix(plugin-chart-echarts): add orderby fix apache#14534 * feat(plugin-chart-echarts): set orderby default value is true
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
* fix(plugin-chart-echarts): add orderby fix apache#14534 * feat(plugin-chart-echarts): set orderby default value is true
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
* fix(plugin-chart-echarts): add orderby fix apache#14534 * feat(plugin-chart-echarts): set orderby default value is true
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vera-liu @mistercrunch @bkyryliuk here is the first PR for the explore refactor.
open questions:
bootstrap_datato a json object? i triedjson.dumps(bootstrap_data)but was getting errors likeCan't serialize ...some object name...