build: add PR lint action #10990
Merged
build: add PR lint action #10990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nytai
force-pushed
the
tai/add-prlint-workflow
branch
from
028735a to
10cf5c2
Compare
nytai
force-pushed
the
tai/add-prlint-workflow
branch
from
d9f2d98 to
bd0f93e
Compare
nytai
force-pushed
the
tai/add-prlint-workflow
branch
from
7800e7f to
99aa49e
Compare
Codecov Report
@@ Coverage Diff @@
## master #10990 +/- ##
==========================================
+ Coverage 61.46% 65.60% +4.14%
==========================================
Files 382 815 +433
Lines 24139 38358 +14219
Branches 0 3607 +3607
==========================================
+ Hits 14836 25164 +10328
- Misses 9303 13086 +3783
- Partials 0 108 +108
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nytai
force-pushed
the
tai/add-prlint-workflow
branch
from
c21fc35 to
df987cc
Compare
mistercrunch
approved these changes
Sep 22, 2020
amitmiran137
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Sep 22, 2020
…l_access/dashboard_by_id_endpoints * upstream/master: (29 commits) fix(presto): default unknown types to string type (apache#10753) feat(row-level-security): add base filter type and filter grouping (apache#10946) docs: add gallery screenshot & link in README (apache#10988) docs: add a "Gallery" page (apache#10968) build: add PR lint action (apache#10990) adding filters back that caused issues (apache#10989) chore: selectors refactor in SQLLab test suite (Cypress) (apache#10944) ESLint: Remove ts-ignore comments (apache#10933) style: fix checkbox color (apache#10970) fix: changed disabled rules in datasets module (apache#10979) fix: update the time filter for 'Last Year' option in explore (apache#10829) fix: use nullpool even for user lookup in the celery (apache#10938) Allow empty observations in alerting (apache#10939) fix: re-enabling several globally disabled lint rules (apache#10957) fix: setting specific exceptions common/query_context.py (apache#10942) Pylint disabled rule `pointless-string-statement` is not raising warining anymore - removing (apache#10975) fix: pylint disabled rules in dashboard/api.py (apache#10976) fix: removed disabled lint rule `too-many-locals` in connectors/base/models.py (apache#10958) ESLint: Re-enable rule no-access-state-in-setstate (apache#10870) fix: simply is_adhoc_metric (apache#10964) ...
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Brings back PR title linting. This time it run as a github actions workflow instead of a bot that depends on apache infra.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION