Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix 'npm run build' + run 'npm audit fix' #10995

Closed
wants to merge 4 commits into from

Conversation

mistercrunch
Copy link
Member

npm run build would fail because the mdxparser doesn't like the comments at the top.

Also ran npm audit fix as npm was reporting some issues.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 22, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2020

Codecov Report

Merging #10995 into master will decrease coverage by 4.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10995      +/-   ##
==========================================
- Coverage   65.77%   61.64%   -4.14%     
==========================================
  Files         815      815              
  Lines       38358    38498     +140     
  Branches     3607     3620      +13     
==========================================
- Hits        25231    23733    -1498     
- Misses      13019    14579    +1560     
- Partials      108      186      +78     
Flag Coverage Δ
#cypress ?
#javascript 62.05% <ø> (+0.31%) ⬆️
#python 61.40% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupFormatters.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupPluginsExtra.js 0.00% <0.00%> (-100.00%) ⬇️
... and 204 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e4a1c8...ca0781c. Read the comment docs.

@willbarrett
Copy link
Member

@mistercrunch this appears to need rebase, and for the license check to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants