Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: saved query list view + sort/filters #11005

Merged
merged 13 commits into from
Sep 29, 2020

Conversation

riahk
Copy link
Contributor

@riahk riahk commented Sep 22, 2020

SUMMARY

  • Convert Saved Queries list to React CRUD page SavedQueryList with ListView
  • Make list sortable
  • Make list filterable by database, schema
  • Make list searchable by query name
  • Disable a cypress test for dashboard edit that keeps breaking CI

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2020-09-22 at 2 31 06 PM

Screen Shot 2020-09-22 at 3 54 16 PM

TEST PLAN

  • Add unit tests to SavedQueryList_spec

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@riahk riahk marked this pull request as ready for review September 24, 2020 16:54
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2020

Codecov Report

Merging #11005 into master will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11005      +/-   ##
==========================================
- Coverage   61.70%   61.41%   -0.30%     
==========================================
  Files         816      383     -433     
  Lines       38586    24188   -14398     
  Branches     3650        0    -3650     
==========================================
- Hits        23808    14854    -8954     
+ Misses      14598     9334    -5264     
+ Partials      180        0     -180     
Flag Coverage Δ
#javascript ?
#python 61.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/queries/saved_queries/api.py 96.22% <ø> (ø)
...t-frontend/src/dashboard/reducers/dashboardInfo.js
...rset-frontend/src/components/Icon/icon.stories.jsx
.../explore/components/controls/CollectionControl.jsx
superset-frontend/src/chart/ChartContainer.jsx
superset-frontend/src/views/CRUD/data/common.ts
...uperset-frontend/src/components/PopoverSection.jsx
superset-frontend/src/SqlLab/reducers/sqlLab.js
superset-frontend/src/utils/common.js
...rset-frontend/src/components/URLShortLinkModal.jsx
... and 423 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a08fd0...80e36ac. Read the comment docs.

@riahk riahk force-pushed the moriah/saved-query-list branch from fed8e1c to 83fa638 Compare September 25, 2020 20:07
@riahk riahk requested a review from nytai September 25, 2020 21:33
@riahk riahk force-pushed the moriah/saved-query-list branch from 4ead2cc to a1e7c24 Compare September 28, 2020 18:40
@riahk riahk force-pushed the moriah/saved-query-list branch from 8bce102 to 9075f8d Compare September 28, 2020 22:56
@riahk riahk requested a review from nytai September 28, 2020 23:38
Copy link
Member

@nytai nytai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge once CI passes

@riahk riahk closed this Sep 29, 2020
@riahk riahk reopened this Sep 29, 2020
@nytai nytai merged commit b8d616a into apache:master Sep 29, 2020
@nytai nytai deleted the moriah/saved-query-list branch September 29, 2020 20:39
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants