Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disabling timezone of dataframe before passing Prophet #11107

Merged
merged 3 commits into from
Sep 30, 2020

Conversation

kkalyan
Copy link
Contributor

@kkalyan kkalyan commented Sep 29, 2020

While running forecasting with Druid. Prophet throws the following exception. This PR removes the timezone info.
ValueError: Column ds has timezone specified, which is not supported. Remove timezone
#11106

@villebro

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

While running forecasting with Druid. Prophet throws the following exception. This PR removes the timezone info. 
ValueError: Column ds has timezone specified, which is not supported. Remove timezone
apache#11106

@villebro
@villebro
Copy link
Member

Thanks @kkalyan , I'll review shortly. I assume this is Druid SQL?

@villebro villebro self-assigned this Sep 29, 2020
@kkalyan
Copy link
Contributor Author

kkalyan commented Sep 29, 2020

@villebro yes, its Druid SQL (version: 0.19.0). After patching this one line change, forecasting worked fine.

superset/utils/pandas_postprocessing.py Outdated Show resolved Hide resolved
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
@villebro
Copy link
Member

@kkalyan the cypress test seems flaky, gonna restart it until it starts working.

@villebro villebro merged commit 0bcc9d7 into apache:master Sep 30, 2020
@kkalyan kkalyan deleted the patch-1 branch October 1, 2020 04:15
dpgaspar pushed a commit that referenced this pull request Oct 1, 2020
* fix: Disabling timezone of dataframe before passing Prophet 

While running forecasting with Druid. Prophet throws the following exception. This PR removes the timezone info. 
ValueError: Column ds has timezone specified, which is not supported. Remove timezone
#11106

@villebro

* Update pandas_postprocessing.py

* Update superset/utils/pandas_postprocessing.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
…1107)

* fix: Disabling timezone of dataframe before passing Prophet 

While running forecasting with Druid. Prophet throws the following exception. This PR removes the timezone info. 
ValueError: Column ds has timezone specified, which is not supported. Remove timezone
apache#11106

@villebro

* Update pandas_postprocessing.py

* Update superset/utils/pandas_postprocessing.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants