Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CRUD REST API for CSS Templates #11114

Merged
merged 4 commits into from
Oct 1, 2020

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Sep 30, 2020

SUMMARY

New CRUD REST API for css templates ( api/v1/css_template )

Screenshot 2020-09-30 at 11 27 29

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar changed the title Feat/api css crud feat: CSS Template CRUD API Sep 30, 2020
@dpgaspar dpgaspar changed the title feat: CSS Template CRUD API feat: CRUD REST API for CSS Templates Sep 30, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2020

Codecov Report

Merging #11114 into master will decrease coverage by 4.51%.
The diff coverage is 91.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11114      +/-   ##
==========================================
- Coverage   65.75%   61.23%   -4.52%     
==========================================
  Files         818      824       +6     
  Lines       38783    38895     +112     
  Branches     3655     3655              
==========================================
- Hits        25501    23817    -1684     
- Misses      13173    14898    +1725     
- Partials      109      180      +71     
Flag Coverage Δ
#cypress ?
#javascript 62.24% <ø> (ø)
#python 60.63% <91.30%> (-0.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/css_templates/dao.py 80.95% <80.95%> (ø)
superset/css_templates/commands/bulk_delete.py 88.46% <88.46%> (ø)
superset/css_templates/filters.py 92.85% <92.85%> (ø)
superset/css_templates/api.py 95.45% <95.45%> (ø)
superset/app.py 80.45% <100.00%> (+0.15%) ⬆️
superset/css_templates/commands/exceptions.py 100.00% <100.00%> (ø)
superset/css_templates/schemas.py 100.00% <100.00%> (ø)
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
... and 187 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa5dab8...0fc09d4. Read the comment docs.

@dpgaspar dpgaspar merged commit fdb26f6 into apache:master Oct 1, 2020
@dpgaspar dpgaspar deleted the feat/api-css-crud branch October 1, 2020 10:46
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
* feat: CSS Template CRUD API

* fix API docs

* fix copy pasta

* lint
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants