fix: Fix Time Column dropdown for date filter #11149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix is much-needed :) |
graceguo-supercat
force-pushed
the
gg-FixTimeColumnDropdown
branch
from
1564ee7 to
83b8d12
Compare
|
force pushed another solution: the root cause for this issue is package changed from |
etr2460
approved these changes
Oct 6, 2020
| @@ -63,9 +63,10 @@ import { | |||
| getSequentialSchemeRegistry, | |||
| legacyValidateInteger, | |||
| validateNonEmpty, | |||
| ColumnOption, | |||
| } from '@superset-ui/core'; | |||
|
|
|||
There was a problem hiding this comment.
nit, remove the newline here (i need to see if i can programatically enforce it with prettier)
graceguo-supercat
force-pushed
the
gg-FixTimeColumnDropdown
branch
from
83b8d12 to
22f1ff2
Compare
Codecov Report
@@ Coverage Diff @@
## master #11149 +/- ##
==========================================
- Coverage 61.68% 61.29% -0.39%
==========================================
Files 827 391 -436
Lines 39061 24485 -14576
Branches 3676 0 -3676
==========================================
- Hits 24094 15009 -9085
+ Misses 14786 9476 -5310
+ Partials 181 0 -181
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
pushed a commit
to preset-io/superset
that referenced
this pull request
Oct 22, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🍒 0.38.0
🍒 0.38.1
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Steps to reproduce this issue:
BEFORE
AFTER
cc @etr2460 @ktmud @mistercrunch