fix: skip unit test that is failing in master for test-postgres-hive #11196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11196 +/- ##
==========================================
- Coverage 65.43% 55.75% -9.68%
==========================================
Files 829 402 -427
Lines 39200 13338 -25862
Branches 3693 3389 -304
==========================================
- Hits 25649 7437 -18212
+ Misses 13444 5714 -7730
- Partials 107 187 +80
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
6 tasks
mistercrunch
reviewed
Oct 8, 2020
tests/datasets/api_tests.py
Outdated
| @@ -864,13 +865,15 @@ def test_export_dataset(self): | |||
| back_references=False, | |||
| include_defaults=False, | |||
| ) | |||
| print(cli_export) | |||
There was a problem hiding this comment.
I added that to debug, since I'm having trouble reproduce the error locally. Will remove after.
betodealmeida
changed the title
6 tasks
dpgaspar
reviewed
Oct 8, 2020
villebro
approved these changes
Oct 8, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
…pache#11196) * Get full diff * Test * Test * Test * Test * Test * Explicitly detect backend to skip test
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Merging #11098 made a unit test start failing in master (9785667). Since the unit test is bypassed out for Presto, I added code to bypass it when the
birth_namestable is not found in the export.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
NA
TEST PLAN
Unit tests now pass in CI.
ADDITIONAL INFORMATION