feat(datasets): REST API bulk delete #11237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11237 +/- ##
==========================================
+ Coverage 65.51% 65.56% +0.04%
==========================================
Files 831 832 +1
Lines 39303 39388 +85
Branches 3592 3592
==========================================
+ Hits 25751 25823 +72
- Misses 13443 13456 +13
Partials 109 109
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
approved these changes
Oct 12, 2020
Comment on lines
+544
to
+548
| message=ngettext( | ||
| "Deleted %(num)d dataset", | ||
| "Deleted %(num)d datasets", | ||
| num=len(item_ids), | ||
| ), |
There was a problem hiding this comment.
Nice, I'll have to start using this, too 👍
| self._models: Optional[List[SqlaTable]] = None | ||
|
|
||
| def run(self) -> None: | ||
| self.validate() |
There was a problem hiding this comment.
Curious, is this something that could be done in a decorator?
There was a problem hiding this comment.
yes, there's some repetition of this one
dpgaspar
added a commit
to preset-io/superset
that referenced
this pull request
Oct 12, 2020
* feat(datasets): REST API bulk delete * doc HTTP 400
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* feat(datasets): REST API bulk delete * doc HTTP 400
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* feat(datasets): REST API bulk delete * doc HTTP 400
mistercrunch
added
🍒 0.38.0
🍒 0.38.1
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
New REST API endpoint for bulk deleting datasets
ADDITIONAL INFORMATION