Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crud): set default extra value when adding database #11262

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

villebro
Copy link
Member

SUMMARY

When adding a new database via the new React CRUD, the connection times out due to the extra field not being prepopulated with default values (they were only shown as a placeholder).

TEST PLAN

Local testing

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Oct 14, 2020

Codecov Report

Merging #11262 into master will decrease coverage by 4.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11262      +/-   ##
==========================================
- Coverage   65.57%   61.38%   -4.20%     
==========================================
  Files         831      831              
  Lines       39514    39512       -2     
  Branches     3598     3598              
==========================================
- Hits        25913    24255    -1658     
- Misses      13492    15075    +1583     
- Partials      109      182      +73     
Flag Coverage Δ
#cypress ?
#javascript 62.66% <100.00%> (+<0.01%) ⬆️
#python 60.62% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/views/CRUD/data/database/DatabaseModal.tsx 60.90% <100.00%> (-10.31%) ⬇️
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupFormatters.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
... and 176 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd7392e...15681e7. Read the comment docs.

@villebro villebro merged commit 2a4ca9f into apache:master Oct 14, 2020
@villebro villebro deleted the villebro/fix-add-db branch October 14, 2020 16:05
dpgaspar pushed a commit to preset-io/superset that referenced this pull request Oct 15, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🍒 0.38.0 🍒 0.38.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🍒 0.38.0 🍒 0.38.1 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants