-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Configured babel plugin for removing data-test from production code #11327
chore: Configured babel plugin for removing data-test from production code #11327
Conversation
retry because of fail in not related test |
Codecov Report
@@ Coverage Diff @@
## master #11327 +/- ##
==========================================
- Coverage 65.66% 62.95% -2.72%
==========================================
Files 835 444 -391
Lines 39656 14987 -24669
Branches 3604 3686 +82
==========================================
- Hits 26042 9435 -16607
+ Misses 13505 5371 -8134
- Partials 109 181 +72
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I still think there's a case for having data-test
attrs in prod, but we can add them back if that time ever comes.
SUMMARY
I added babel plugin for production debug babel variant - it trims data-test from production code. It requires passing BABEL_ENV=production while building prod.
I observed that it is not applicable for inputProps:
and for code in templates in superset/ directory:
It is working for
So I think the next step is to wrap somehow elements from superset/ and replace inputProps with some other wrapper for elements.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before:
after:
TEST PLAN
ADDITIONAL INFORMATION