Fix initialization of Database sqlalchemy_uri and password #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…baseView.pre_add to utils.get_or_create_main_db. Unit tests for mysql and postgres include username and password in the SQLALCHEMY_DATABASE_URI.
|
Nice! great work! |
dennisobrien
deleted the
dennisobrien/bugfix_init_db_username_password
branch
dennisobrien
added a commit
to dennisobrien/caravel
that referenced
this pull request
Sep 22, 2016
…e password is stored encrypted. This fixes a regression I introduced with PR apache#1137
This was referenced Sep 22, 2016
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move initialization of Database sqlalchemy_uri and password from DatabaseView.pre_add to utils.get_or_create_main_db. This fixes an issue where a clean install of Caravel using a database with a username and password failed to initialize properly.
Updates the unit tests for mysql and postgres to include username and password in the SQLALCHEMY_DATABASE_URI. Previously, including a username and password in these URIs would lead to failing tests.
This fixes issue #1070
This supercedes PR #1092 (now closed).