Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Disabled Bubble test #11630

Merged

Conversation

adam-stasiak
Copy link
Contributor

SUMMARY

I observed that test which I enabled recently in some runs started to fail - After try of reproduce I also had unstable runs this time. I tried to fix this but failed. I suggest skipping again.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Nov 9, 2020

Codecov Report

Merging #11630 (2e370b8) into master (5be1dbe) will increase coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11630      +/-   ##
==========================================
+ Coverage   61.92%   62.26%   +0.34%     
==========================================
  Files         422      873     +451     
  Lines       26295    42280   +15985     
  Branches        0     3964    +3964     
==========================================
+ Hits        16282    26326   +10044     
- Misses      10013    15774    +5761     
- Partials        0      180     +180     
Flag Coverage Δ
javascript 62.83% <ø> (?)
python 61.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ard/components/filterscope/FilterScopeSelector.jsx 1.42% <0.00%> (ø)
...ntend/src/dashboard/util/getRevertedFilterScope.ts 11.76% <0.00%> (ø)
...t-frontend/src/dashboard/components/IconButton.jsx 100.00% <0.00%> (ø)
...perset-frontend/src/components/CopyToClipboard.jsx 35.93% <0.00%> (ø)
...d/src/dashboard/util/logging/childChartsDidLoad.js 0.00% <0.00%> (ø)
...rontend/src/explore/components/AggregateOption.jsx 100.00% <0.00%> (ø)
...-frontend/src/explore/components/ControlHeader.jsx 70.37% <0.00%> (ø)
superset-frontend/src/components/CheckboxIcons.tsx 85.71% <0.00%> (ø)
...ews/CRUD/annotationlayers/AnnotationLayersList.tsx 77.88% <0.00%> (ø)
...lore/components/controls/withAsyncVerification.tsx 83.60% <0.00%> (ø)
... and 441 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be1dbe...2e370b8. Read the comment docs.

@mistercrunch mistercrunch merged commit 4d41cf9 into apache:master Nov 10, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants