Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring DB in sync with the models.py #1172

Merged
merged 2 commits into from
Sep 28, 2016
Merged

Bring DB in sync with the models.py #1172

merged 2 commits into from
Sep 28, 2016

Conversation

bkyryliuk
Copy link
Member

@bkyryliuk bkyryliuk commented Sep 22, 2016 •
edited
Loading

Fixes #466 and cleans up the result of the caravel db migrate.
In addition this change makes client_id unique and updates the tests.

Tested via on MySQL:

caravel db history
caravel db upgrade 
caravel db downgrade eca4694defa7
caravel db upgrade

SQL Lite doesn't support most of the operations here.

Reviewers:

@bkyryliuk bkyryliuk changed the title Bring DB in sync with the models.py Work in Progress. Bring DB in sync with the models.py Sep 23, 2016
xrmx
xrmx reviewed Sep 23, 2016
View reviewed changes
caravel/models.py
@@ -664,6 +664,7 @@ class SqlaTable(Model, Queryable, AuditMixinNullable):
table_name = Column(String(250))
main_dttm_col = Column(String(250))
description = Column(Text)
default_endpoint = Column(Text)
Copy link
Contributor

@xrmx xrmx Sep 23, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this intended? I see you are removing it in the other commit, so maybe just don't add it here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't intend to delete it.

@bkyryliuk bkyryliuk changed the title Work in Progress. Bring DB in sync with the models.py Bring DB in sync with the models.py Sep 23, 2016
@mistercrunch
Copy link
Member

LGTM

@bkyryliuk bkyryliuk merged commit 9c83b90 into apache:master Sep 28, 2016
@bkyryliuk bkyryliuk deleted the add_column_foreign_keys branch September 28, 2016 20:55
This was referenced Jul 17, 2020
Open
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 22, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Oct 16, 2021
Closed
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@kgabryje @zhaoyongjie
feat(plugin-chart-pivot-table): enable metrics to be used as row grou…
6249793 
…ps (apache#1172)
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@kgabryje @zhaoyongjie
feat(plugin-chart-pivot-table): enable metrics to be used as row grou…
ef685f1 
…ps (apache#1172)
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@kgabryje @zhaoyongjie
feat(plugin-chart-pivot-table): enable metrics to be used as row grou…
3810d90 
…ps (apache#1172)
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@kgabryje @zhaoyongjie
feat(plugin-chart-pivot-table): enable metrics to be used as row grou…
cb5e908 
…ps (apache#1172)
This was referenced Feb 1, 2022
Open
Open
Closed
Open
@snyk-bot snyk-bot mentioned this pull request Feb 21, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Jun 9, 2022
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Jun 22, 2022
Closed
@m-ajay m-ajay mentioned this pull request Sep 27, 2022
Open
This was referenced Sep 27, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 6, 2022
Open
This was referenced Oct 6, 2022
Open
Open
@m-ajay m-ajay mentioned this pull request Oct 6, 2022
Open
This was referenced Oct 9, 2022
Open
Open
This was referenced Oct 19, 2022
Closed
Closed
@terrorizer1980 terrorizer1980 mentioned this pull request May 24, 2023
Closed
@laxmanraparthi laxmanraparthi mentioned this pull request Jun 28, 2023
Open
@lili2311 lili2311 mentioned this pull request Jul 4, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Jul 4, 2023
Closed
@mariasnyk mariasnyk mentioned this pull request Jul 4, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Jul 5, 2023
Closed
@xiezhongfu xiezhongfu mentioned this pull request Jul 5, 2023
Open
@xiezhongfu xiezhongfu mentioned this pull request Nov 26, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Nov 29, 2023
Closed
@lili2311 lili2311 mentioned this pull request Nov 29, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Nov 30, 2023
Closed
@xiezhongfu xiezhongfu mentioned this pull request Dec 19, 2023
Open
This was referenced Dec 19, 2023
Closed
Closed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 labels Feb 19, 2024
This was referenced Apr 29, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrmx xrmx xrmx left review comments

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the wrong foreign key on columns.column_name
3 participants
@bkyryliuk @mistercrunch @xrmx