Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pr kevin #11872

Closed
wants to merge 2 commits into from
Closed

Test pr kevin #11872

wants to merge 2 commits into from

Conversation

Gitonga-Kevin
Copy link

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

collins-b and others added 2 commits November 24, 2020 09:35
* Fix CI by adding a minimal Travis config
@codecov-io
Copy link

codecov-io commented Dec 1, 2020

Codecov Report

Merging #11872 (5a61473) into master (a9f9c4b) will increase coverage by 1.85%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11872      +/-   ##
==========================================
+ Coverage   65.76%   67.61%   +1.85%     
==========================================
  Files         873      924      +51     
  Lines       42316    44837    +2521     
  Branches     3972     4253     +281     
==========================================
+ Hits        27827    30315    +2488     
- Misses      14374    14419      +45     
+ Partials      115      103      -12     
Flag Coverage Δ
cypress 55.15% <ø> (+4.71%) ⬆️
javascript 63.03% <ø> (+0.18%) ⬆️
python 64.15% <ø> (+2.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-60.72%) ⬇️
...nd/src/dashboard/util/getFilterValuesByFilterId.js 25.00% <0.00%> (-50.00%) ⬇️
superset/utils/cache.py 57.57% <0.00%> (-18.43%) ⬇️
...rontend/src/visualizations/FilterBox/FilterBox.jsx 58.12% <0.00%> (-13.75%) ⬇️
...t-frontend/src/dashboard/util/setPeriodicRunner.ts 70.00% <0.00%> (-10.00%) ⬇️
superset-frontend/src/SqlLab/components/App.jsx 60.00% <0.00%> (-9.24%) ⬇️
...ontend/src/components/CertifiedIconWithTooltip.tsx 60.00% <0.00%> (-6.67%) ⬇️
superset-frontend/src/components/Select/utils.ts 94.11% <0.00%> (-5.89%) ⬇️
...ntend/src/dashboard/util/activeDashboardFilters.js 90.38% <0.00%> (-5.77%) ⬇️
superset-frontend/src/components/Select/styles.tsx 92.75% <0.00%> (-5.40%) ⬇️
... and 246 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9f9c4b...5a61473. Read the comment docs.

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a .travis.yml file? We're not using Travis for our CI checks anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants