-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Replace Well componenet with Card component #12200
chore: Replace Well componenet with Card component #12200
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12200 +/- ##
==========================================
- Coverage 67.11% 64.12% -3.00%
==========================================
Files 996 485 -511
Lines 49176 29867 -19309
Branches 4993 0 -4993
==========================================
- Hits 33006 19151 -13855
+ Misses 16047 10716 -5331
+ Partials 123 0 -123
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I think it is deviating from the approach that we recently took to enhance the Antdesign components using Emotion. Please have a look at my comments
Thanks for the PR @nikolagigic! |
@nikolagigic Thanks for the PR. Can you please reference #10254 in the PR description? |
Not a problem 🙂 Hello @nikolagigic! |
@nikolagigic Can we export the Card from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikolagigic Sorry this one has been sitting here so long, but I think we'll be OK to merge it now. It looks like all comments were addressed, so I've marked them as resolved, and I'm approving.
I also saw the E2E tests were failing for some reason. I've closed/reopened to kick CI, so fingers crossed that it works 🤞 Please give this a rebase, and assess any failing Cypress tests if needed, and it should be good to go.
@junlincc Probably ought to give it a quick pass for Product/QA signoff before we merge, or delegate that job to anyone else she deems fit.
* replace Well componenet with Card component * Fix lint errors * Fix lint * Addressing comments * Addressing comments * Fix lint errors * Exporting Card from index.tsx and adding storybook variants * Fix some refactoring * Fix errors * solving conflicts and lint errors * Update superset-frontend/src/common/components/Card.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/common/components/Card.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/common/components/common.stories.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/common/components/common.stories.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/common/components/common.stories.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/common/components/common.stories.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/common/components/common.stories.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Nikola Gigic <nik.gigic@gmail.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
…ache#14033) * replace Well componenet with Card component * Fix lint errors * Fix lint * Addressing comments * Addressing comments * Fix lint errors * Exporting Card from index.tsx and adding storybook variants * Fix some refactoring * Fix errors * solving conflicts and lint errors * Update superset-frontend/src/common/components/Card.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/common/components/Card.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/common/components/common.stories.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/common/components/common.stories.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/common/components/common.stories.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/common/components/common.stories.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/common/components/common.stories.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Nikola Gigic <nik.gigic@gmail.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
…ache#14033) * replace Well componenet with Card component * Fix lint errors * Fix lint * Addressing comments * Addressing comments * Fix lint errors * Exporting Card from index.tsx and adding storybook variants * Fix some refactoring * Fix errors * solving conflicts and lint errors * Update superset-frontend/src/common/components/Card.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/common/components/Card.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/common/components/common.stories.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/common/components/common.stories.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/common/components/common.stories.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/common/components/common.stories.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/common/components/common.stories.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Nikola Gigic <nik.gigic@gmail.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
SUMMARY
Replace react-bootstrap Well component with customised AntD Card component
#10254
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
ADDITIONAL INFORMATION