-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: inline external Github Actions to unblock CI #12241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on. Minor typo, other than that makes sense and LGTM.
Codecov Report
@@ Coverage Diff @@
## master #12241 +/- ##
==========================================
- Coverage 66.20% 59.37% -6.84%
==========================================
Files 996 946 -50
Lines 49174 46561 -2613
Branches 4993 4299 -694
==========================================
- Hits 32554 27644 -4910
- Misses 16476 18917 +2441
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Also fixes pre-commit
b187d33
to
9c5ca12
Compare
I'm going to merge this to unblock the long list of PRs. |
massive take on! really appreciate your help! @ktmud 🙏 |
SUMMARY
Apache changed policy on Github Actions because of security risks. Now official apache repos can only run a list of allowed actions.
CI has been blocked by this error:
This PR unblocks CI by
Remove
styfle/cancel-workflow-action
, which may soon become obsolete if build: try to speed up Github workflows #11944 gets mergedMove all other external dependencies to be within current repo, including:
These actions were copied over via downloading them as ZIP files directly from GitHub. All of these actions use the MIT license so I'd assume there is no licensing issue.
Change
pull_request_target
trigger for the E2E action topull_request
. This is needed for unblocking the CI that runs on existing workflow configs. This will also prevent future Pwn requests and we don't plan to bring it back.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
CI should pass
ADDITIONAL INFORMATION