Adding a color factory #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughhhh
added a commit
to lyft/incubator-superset
that referenced
this pull request
Apr 1, 2018
Adding check to make sure confidant keys from TOM are the same in header. Refactor on `lyft.py` realized i can just override `generate_json()` and get the same result.
New Endpoints:
explore_json: `superset:8080/lyft/explore_json/table/3/?form_data={...}`
dashboard: `superset:8080/lyft/dashboard/4/?json=true` (apache#4337)
@mistercrunch
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
Nov 9, 2018
Apache sync: cherrypick fixes
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 4, 2021
* fix: 🐛 Fixed typ definiton for chart plugin This PR is to fix the type definiton for transformProps and LoadData. * fix: 🐛 Type compatibility Change the output of preTransformProps to ChartProps * fix: 🐛 Fixed Test Fixed the test according to the changes:
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 17, 2021
* fix: 🐛 Fixed typ definiton for chart plugin This PR is to fix the type definiton for transformProps and LoadData. * fix: 🐛 Type compatibility Change the output of preTransformProps to ChartProps * fix: 🐛 Fixed Test Fixed the test according to the changes:
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 17, 2021
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 24, 2021
* fix: 🐛 Fixed typ definiton for chart plugin This PR is to fix the type definiton for transformProps and LoadData. * fix: 🐛 Type compatibility Change the output of preTransformProps to ChartProps * fix: 🐛 Fixed Test Fixed the test according to the changes:
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 24, 2021
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 25, 2021
* fix: 🐛 Fixed typ definiton for chart plugin This PR is to fix the type definiton for transformProps and LoadData. * fix: 🐛 Type compatibility Change the output of preTransformProps to ChartProps * fix: 🐛 Fixed Test Fixed the test according to the changes:
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 25, 2021
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 26, 2021
* fix: 🐛 Fixed typ definiton for chart plugin This PR is to fix the type definiton for transformProps and LoadData. * fix: 🐛 Type compatibility Change the output of preTransformProps to ChartProps * fix: 🐛 Fixed Test Fixed the test according to the changes:
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 26, 2021
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is opening the door for sequential color attribution OR hash-based (previous default)