Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: /postgres engine spec test coverage #12490

Merged
merged 5 commits into from
Jan 15, 2021

Conversation

kstrz
Copy link
Contributor

@kstrz kstrz commented Jan 13, 2021

SUMMARY

Increase postgres engine spec test coverage.
Fix estimate_statement_cost for invalid syntax

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few quick first pass comments

superset/db_engine_specs/postgres.py Outdated Show resolved Hide resolved
tests/db_engine_specs/postgres_tests.py Outdated Show resolved Hide resolved
@kstrz
Copy link
Contributor Author

kstrz commented Jan 13, 2021

Hey! Could you look at it? @willbarrett @dpgaspar

@codecov-io
Copy link

codecov-io commented Jan 13, 2021

Codecov Report

Merging #12490 (426c502) into master (7aba4c2) will decrease coverage by 2.45%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12490      +/-   ##
==========================================
- Coverage   66.29%   63.84%   -2.46%     
==========================================
  Files        1015      486     -529     
  Lines       49554    29938   -19616     
  Branches     5079        0    -5079     
==========================================
- Hits        32854    19114   -13740     
+ Misses      16562    10824    -5738     
+ Partials      138        0     -138     
Flag Coverage Δ
cypress ?
javascript ?
python 63.84% <81.81%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/databases/schemas.py 99.45% <ø> (-0.55%) ⬇️
superset/db_engine_specs/druid.py 88.63% <33.33%> (+27.27%) ⬆️
superset/db_engine_specs/postgres.py 96.05% <89.47%> (+10.08%) ⬆️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/db_engine_specs/mysql.py 79.59% <0.00%> (-12.25%) ⬇️
superset/db_engine_specs/sqlite.py 65.62% <0.00%> (-9.38%) ⬇️
superset/databases/commands/create.py 83.67% <0.00%> (-8.17%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/databases/commands/test_connection.py 84.78% <0.00%> (-4.35%) ⬇️
superset/utils/celery.py 96.42% <0.00%> (-3.58%) ⬇️
... and 543 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40a334a...426c502. Read the comment docs.

Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you post the current coverage and the new coverage after the PR?

superset/db_engine_specs/postgres.py Outdated Show resolved Hide resolved
@villebro
Copy link
Member

@kstrz this needs to be rebased

@kstrz kstrz force-pushed the testing/db-engine-spec-coverage branch from d25479b to 426c502 Compare January 13, 2021 12:09
@kstrz
Copy link
Contributor Author

kstrz commented Jan 14, 2021

Coverage for superset/db_engine_specs/postgres.py on master: 85.96% , on current branch: 96.05%

@villebro villebro merged commit fc5e311 into apache:master Jan 15, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants