-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: /postgres engine spec test coverage #12490
test: /postgres engine spec test coverage #12490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few quick first pass comments
Hey! Could you look at it? @willbarrett @dpgaspar |
Codecov Report
@@ Coverage Diff @@
## master #12490 +/- ##
==========================================
- Coverage 66.29% 63.84% -2.46%
==========================================
Files 1015 486 -529
Lines 49554 29938 -19616
Branches 5079 0 -5079
==========================================
- Hits 32854 19114 -13740
+ Misses 16562 10824 -5738
+ Partials 138 0 -138
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can you post the current coverage and the new coverage after the PR?
@kstrz this needs to be rebased |
d25479b
to
426c502
Compare
Coverage for superset/db_engine_specs/postgres.py on master: 85.96% , on current branch: 96.05% |
SUMMARY
Increase postgres engine spec test coverage.
Fix estimate_statement_cost for invalid syntax
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION