Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update contribution guide #12571

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

amitmiran137
Copy link
Member

SUMMARY

update explanations about running common tasks like pylint and… pre-commit

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Jan 16, 2021

Codecov Report

Merging #12571 (66e094b) into master (deebd6f) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12571      +/-   ##
==========================================
- Coverage   66.75%   66.75%   -0.01%     
==========================================
  Files        1015     1015              
  Lines       49633    49633              
  Branches     4839     4839              
==========================================
- Hits        33133    33131       -2     
- Misses      16377    16379       +2     
  Partials      123      123              
Flag Coverage Δ
cypress 50.98% <ø> (+<0.01%) ⬆️
javascript 60.74% <ø> (ø)
python 63.95% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/presto.py 81.38% <0.00%> (-0.65%) ⬇️
...set-frontend/src/dashboard/util/getDropPosition.js 93.65% <0.00%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deebd6f...66e094b. Read the comment docs.

@villebro villebro merged commit 377f70b into apache:master Jan 18, 2021
@amitmiran137 amitmiran137 deleted the chore/update_contibution_guide branch January 31, 2021 11:42
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants