Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump socket.io from 2.3.0 to 2.4.1 in /docs #12636

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 21, 2021

Bumps socket.io from 2.3.0 to 2.4.1.

Release notes

Sourced from socket.io's releases.

2.4.1

This release reverts the breaking change introduced in 2.4.0 (socketio/socket.io@f78a575).

If you are using Socket.IO v2, you should explicitly allow/disallow cross-origin requests:

  • without CORS (server and client are served from the same domain):
io.origins((req, callback) => {
  callback(null, req.headers.origin === undefined); // cross-origin requests will not be allowed
});
  • with CORS (server and client are served from distinct domains):
io.origins(["http://localhost:3000"]); // for local development
io.origins(["https://example.com"]);

In any case, please consider upgrading to Socket.IO v3, where this security issue is now fixed (CORS is disabled by default).

Reverts

  • fix(security): do not allow all origins by default (a169050)

Links:

2.4.0

Related blog post: https://socket.io/blog/socket-io-2-4-0/

Features (from Engine.IO)

  • add support for all cookie options (19cc582)
  • disable perMessageDeflate by default (5ad2736)

Bug Fixes

  • security: do not allow all origins by default (f78a575)
  • properly overwrite the query sent in the handshake (d33a619)

⚠️ BREAKING CHANGE ⚠️

Previously, CORS was enabled by default, which meant that a Socket.IO server sent the necessary CORS headers (Access-Control-Allow-xxx) to any domain. This will not be the case anymore, and you now have to explicitly enable it.

... (truncated)

Changelog

Sourced from socket.io's changelog.

2.4.1 (2021-01-07)

Reverts

  • fix(security): do not allow all origins by default (a169050)

2.4.0 (2021-01-04)

Bug Fixes

  • security: do not allow all origins by default (f78a575)
  • properly overwrite the query sent in the handshake (d33a619)
Commits
  • e6b8697 chore(release): 2.4.1
  • a169050 revert: fix(security): do not allow all origins by default
  • 873fdc5 chore(release): 2.4.0
  • f78a575 fix(security): do not allow all origins by default
  • d33a619 fix: properly overwrite the query sent in the handshake
  • 3951a79 chore: bump engine.io version
  • 6fa026f ci: migrate to GitHub Actions
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added .dependency Add new or update dependencies javascript Dependabot - Pull requests that update Javascript code labels Jan 21, 2021
@codecov-io
Copy link

codecov-io commented Jan 21, 2021

Codecov Report

Merging #12636 (b9a2151) into master (21cc495) will decrease coverage by 13.71%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #12636       +/-   ##
===========================================
- Coverage   77.41%   63.69%   -13.72%     
===========================================
  Files         918      486      -432     
  Lines       46673    29984    -16689     
  Branches     5720        0     -5720     
===========================================
- Hits        36131    19098    -17033     
- Misses      10406    10886      +480     
+ Partials      136        0      -136     
Flag Coverage Δ
cypress ?
hive ?
javascript ?
mysql ?
postgres ?
presto ?
python 63.69% <ø> (-17.41%) ⬇️
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/db_engine_specs/sqlite.py 65.62% <0.00%> (-31.25%) ⬇️
superset/db_engine_specs/hana.py 70.00% <0.00%> (-25.00%) ⬇️
superset/db_engine_specs/pinot.py 70.73% <0.00%> (-24.27%) ⬇️
superset/views/redirects.py 70.00% <0.00%> (-18.38%) ⬇️
superset/databases/commands/test_connection.py 84.78% <0.00%> (-13.14%) ⬇️
superset/db_engine_specs/oracle.py 81.81% <0.00%> (-12.13%) ⬇️
superset/datasets/dao.py 87.28% <0.00%> (-9.38%) ⬇️
superset/databases/commands/create.py 83.67% <0.00%> (-8.49%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
... and 900 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21cc495...d223b29. Read the comment docs.

@nytai nytai closed this Mar 16, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 16, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@nytai nytai reopened this Mar 16, 2021
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/docs/socket.io-2.4.1 branch from de749bb to d223b29 Compare March 16, 2021 20:16
@willbarrett willbarrett merged commit 353038e into master Apr 13, 2021
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/docs/socket.io-2.4.1 branch April 13, 2021 21:01
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
Bumps [socket.io](https://github.com/socketio/socket.io) from 2.3.0 to 2.4.1.
- [Release notes](https://github.com/socketio/socket.io/releases)
- [Changelog](https://github.com/socketio/socket.io/blob/2.4.1/CHANGELOG.md)
- [Commits](socketio/socket.io@2.3.0...2.4.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels .dependency Add new or update dependencies javascript Dependabot - Pull requests that update Javascript code size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants