Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard_rbac): dashboards API support for roles create/update + roles validation #12865

Merged
merged 11 commits into from
Feb 7, 2021

Conversation

amitmiran137
Copy link
Member

SUMMARY

the needed support for managing roles via v1 API to be used from the UI and for app 2 app calls
resolves #10408

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@amitmiran137 amitmiran137 changed the title feat(dashboard_RBAC: dashboards API support for roles create/update + roles validation feat(dashboard_rbac): dashboards API support for roles create/update + roles validation Feb 1, 2021
@amitmiran137
Copy link
Member Author

@ktmud @villebro Could you review?

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

superset/commands/utils.py Outdated Show resolved Hide resolved
superset/dashboards/commands/create.py Outdated Show resolved Hide resolved
superset/dashboards/commands/update.py Show resolved Hide resolved
tests/base_tests.py Outdated Show resolved Hide resolved
amitmiran137 and others added 3 commits February 1, 2021 18:40
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
@codecov-io
Copy link

codecov-io commented Feb 1, 2021

Codecov Report

Merging #12865 (9400161) into master (9a7fba8) will decrease coverage by 3.33%.
The diff coverage is 90.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12865      +/-   ##
==========================================
- Coverage   67.04%   63.71%   -3.34%     
==========================================
  Files        1022      490     -532     
  Lines       50186    30271   -19915     
  Branches     5204        0    -5204     
==========================================
- Hits        33647    19287   -14360     
+ Misses      16404    10984    -5420     
+ Partials      135        0     -135     
Flag Coverage Δ
cypress ?
javascript ?
python 63.71% <90.19%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/dashboards/api.py 86.63% <ø> (ø)
superset/dashboards/commands/update.py 83.07% <70.58%> (-5.61%) ⬇️
superset/commands/exceptions.py 92.00% <100.00%> (+0.69%) ⬆️
superset/commands/utils.py 100.00% <100.00%> (ø)
superset/dashboards/commands/create.py 93.87% <100.00%> (+1.56%) ⬆️
superset/dashboards/schemas.py 98.83% <100.00%> (+0.04%) ⬆️
superset/security/manager.py 91.07% <100.00%> (+0.05%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/db_engine_specs/hive.py 73.84% <0.00%> (-17.31%) ⬇️
... and 557 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a7fba8...9400161. Read the comment docs.

Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one tiny tiny nit

superset/commands/exceptions.py Outdated Show resolved Hide resolved
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
@junlincc junlincc added the dashboard:security:access Related to the security access of the Dashboard label Feb 1, 2021
superset/commands/utils.py Outdated Show resolved Hide resolved
superset/security/manager.py Outdated Show resolved Hide resolved
amitmiran137 and others added 3 commits February 4, 2021 10:49
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
@amitmiran137 amitmiran137 reopened this Feb 7, 2021
@villebro villebro merged commit 8ccf2e8 into apache:master Feb 7, 2021
@amitmiran137 amitmiran137 deleted the feat/dashboard_roles_api branch February 7, 2021 17:48
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:security:access Related to the security access of the Dashboard size/L 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SIP-51] Dashboard Level Access
6 participants